ziin wrote:
Add in a "skin mode". Or add the skin specific stuff (like fruit-plate, selection mods, and circle highlight) in a "skin" tab, and apply its own custom skinset (like how hitcircle, hitcircleoverlay, and approach circle have to be together). If someone has a skin specific file in the beatmap, treat it like a skin, and put a notice at the top saying "if this is not a skin, you have an unnecessary skin file in your map and should remove it".
... I always miss the obvious, practical solutions.
ziin wrote:
You can try reading the id3 tag, but the best way is to figure out the song duration.
And: http://stackoverflow.com/questions/3046 ... me-in-java
Alright, from there I found a magical library that gets the bitrate directly for me; I might not even need song duration anymore! Also, does anyone have an mp3 file with a Variable Bit Rate and a known average to provide me for testing the bitrate that the library give me?
ziin wrote:
Also, I'm not sure which skin elements you check, but these are the important ones:
approachcircle
hitcircle
hitcircleoverlay
cursor
hit0 etc...
Questionable:
fruits
One thing you can do is check each and make a note that "X" is (much) bigger than the template skin dimensions.
You could try digging through the source code, it should be understandable. Maybe
. Anyways, currently they are:
hitcircle, approachcircle, hitcircle overlay must all be 128x128
hit0... to hit300g must be 256x256
spinnercircle must be 666x666
pauseoverlay, playfield must be 1024x768
comboburst must be less than 500x767
I guess I'm missing cursor and fruits, what are the dimensions for those?
Sakura Hana wrote:
Audio Lead-in wise i think 1.5 - 2 seconds before the approach circle appears is fine enough, however that would need a human modder probably (unless you can calculate time with approach rate), so i'd say 2 seconds until the first note should be enough, any less and throw a warning
Alright, I think a warning for under 2 seconds would be good, and perhaps a stronger one if it's under 1?
blissfulyoshi wrote:
I forgot if this was reported already, but it seems that .png files inside a folder aren't reported correctly.
... tried to use != instead of !.equals() on a string. Anyways, it should be fixed now.
blissfulyoshi wrote:
Also, if some but not all of the kiai timings match up exactly in every diff, could you not post them. (so if only one kiai section is inconsistent among all the diffs, could you only post that one section?)
Aww... that would involve changing how Kiai is checked- I was lazy and just compared the entire thing as strings, which was easier. Which is probably bad coding. Put under TODO.
blissfulyoshi wrote:
Bug: AIBat suggest there should be an epilepsy warning even if epilepsy warning is on.
I couldn't reproduce this, could you tell me which folder you were using when this happened?
Lybydose wrote:
Why does this matter? The only green sections that need to be snapped are those that start kiai and those that end kiai, and even end kiai is questionable.
Yeah, I've heard that. Besides what Sakura said, I just kind of like maps to be nice and neat and snapped (I once popped a bubble to fix one of my maps in that regard). If other's don't care about such things and don't want to change it they can just ignore those warnings, I guess.