Guest
home
beatmaps
rankings
community
store
help
forum
  1. Forums
  2. osu!
  3. Development
  4. Completed Projects

AIBat v3.1 - v10 Compatibility

posted
Total Posts
327
show more
Sakura
osu! Alumni
7,979 posts
Joined March 2010
Sakura
Ok just tried the program myself, and there's some stuff i'd like to point out:
- Not sure how useful exporting the whole thing to clipboard can be, it would be better if you can click on a warning and it copies the timeline minutes:seconds:miliseconds when clicking on timing section warnings or for notes/spinners/sliders minutes:seconds:miliseconds (combonumbers), so that it can be found faster inside the map when needed.
- It'd be better if the difficulties were arranged by star rating, rather than alphabetically, just like osu! itself does (when identical star rating, it then orders them alphabetically).
awp
osu! Alumni
11,869 posts
Here since the beginning
awp
Identical star rating? Poor map design!
Sakura
osu! Alumni
7,979 posts
Joined March 2010
Sakura
I know, but so it doesnt break when checking for it

Edit: Or when there are multiple maps at 5.00 star rating (since it can't go higher)
akrolsmir
606 posts
Joined November 2010
Topic Starter
akrolsmir

Sakura Hana wrote:

Ok just tried the program myself, and there's some stuff i'd like to point out:
- Not sure how useful exporting the whole thing to clipboard can be, it would be better if you can click on a warning and it copies the timeline minutes:seconds:miliseconds when clicking on timing section warnings or for notes/spinners/sliders minutes:seconds:miliseconds (combonumbers), so that it can be found faster inside the map when needed.
- It'd be better if the difficulties were arranged by star rating, rather than alphabetically, just like osu! itself does (when identical star rating, it then orders them alphabetically).
I think I should be able to implement the first, with HTML. It's a very good idea- in absence of AIMod's ability to transfer the clicked time directly to a certain note, this would be the next best substitute.

The second was something I also considered, but I'm unsure of how to determine difficulty stars. Apparently (according to the Term Glossary, if that's not outdated) difficulty is calculated with eyup's algorithm... and I have absolutely no idea how that works. Is this the kind of thing that'd be appropriate to contact Peppy for? Alternatively, I could roughly approximate difficulty with something like number of hitobjects- not a flawless approach, but reasonably functional.
blissfulyoshi
osu! Alumni
4,755 posts
Joined July 2008
blissfulyoshi

akrolsmir wrote:

First two comments about stack leniency were both implemented. What are the acceptable ranges for stack leniency and circle size?
Stack leniency: 0.2 is the minimum available in editor but a lot of BATs like 0.3 and higher
Circle size: 3-7 are available in editor
On another note, I think the editor should output something similar to mod post, so:
00:06:154 (1) - The start of the spinner at 00:06:154 (1) is unsnapped.

Okay time to test the newest version
akrolsmir
606 posts
Joined November 2010
Topic Starter
akrolsmir

blissfulyoshi wrote:

akrolsmir wrote:

First two comments about stack leniency were both implemented. What are the acceptable ranges for stack leniency and circle size?
Stack leniency: 0.2 is the minimum available in editor but a lot of BATs like 0.3 and higher
Circle size: 3-7 are available in editor
On another note, I think the editor should output something similar to mod post, so:
00:06:154 (1) - The start of the spinner at 00:06:154 (1) is unsnapped.

Okay time to test the newest version
Okay, I'll implement a circle size check. And perhaps warn against circle size 3 as well?

I've simplified the output and formatted it, similar to forums (though I haven't released it in the update yet). Below is a sample of how the export looks now:

AIBat Warnings
These warnings were generated by AIBat.

[General]
No problems found.

[Storyboard]
No problems found.

[All .osu Files]
Inconsistency in SkinPreference:
- [Hard] :
- [Test] : Ecchi


Inconsistency in uninherited (red) timing sections:
- [Hard]
Red timing points at:
00:00:536

- [Test]
Red timing points at:
00:00:536
00:05:678


There are no tags, consider adding some.


[Difficulty: Hard]
00:00:536 (1) - The spinner here is 42376 ms long, which is longer than 7500 ms.

The stack leniency is set to 0.2, which is below the recommended leniency of 0.3


[Difficulty: Test]
00:06:154 (1) - The start of the spinner here is unsnapped.
00:06:154 (1) - The end of the spinner here is unsnapped.
00:19:958 (1) - The start of the spinner here is unsnapped.
00:19:958 (1) - The end of the spinner here is unsnapped.
00:36:491 (1) - The circle here is unsnapped.
00:36:652 (2) - The circle here is unsnapped.
00:36:812 (3) - The circle here is unsnapped.
00:36:813 (4) - The circle here is unsnapped.
00:36:973 (5) - The circle here is unsnapped.
00:39:060 (1) - The start of the spinner here is unsnapped.
00:39:060 (1) - The end of the spinner here is unsnapped.
00:44:357 (1) - The circle here is unsnapped.
01:09:878 (1) - The circle here is unsnapped.
01:16:620 (1) - The circle here is unsnapped.

Unsnapped inherited (green) timing point(s) at:
00:07:438

00:06:154 (1) - The spinner here is 12520 ms long, which is longer than 7500 ms.
00:19:958 (1) - The spinner here is 321 ms long, which is shorter than 750 ms.

00:01:178 (1) - This slider is a Catmull slider, which is discouraged.

(Now to check for a million SB things- I had no idea that was so complicated! >.< )
lolcubes
osu! Alumni
4,437 posts
Joined November 2010
lolcubes
I suggest one more thing. Considering this will help in modding, which means occasional rechecking, that after you check a map, it generates a mini database (can be in .txt, you just format it so it reads it just like it's scanning files) which is stored somewhere, probably let user decide where if you wish, or just generate it in the map folder (and then add a check when you run the program to see if such a file already exists in the folder, probably needs a standard name).
I suggest this, because usually it takes a lot of time to recheck something, and when a mod is complete and you want to recheck it, you can just see the differences between the 2 mapsets (i mean the mapset before and the mapset after the mod) easily from the .txt files (or whatever extension you feel using for this kind of work).

Also in addition to this, you can add an option to generate a new file every time (like standardname_1, standardname_2, etc, ofc original being _0) or to overwrite, depending what the user wants. This will let the user control the amount of "spam" he could get in that folder.

Oh and one more thing, when we're talking about snapping @timeline, I suggest that you make a check for 1/6ths and 1/8ths as well. They might be placed correctly, but usually (depends on the mapping experience obviously) it may not be, so you could just list where these are in case someone misses those.
This could add quite some effort to coding, but consider putting these to the "to do" list if you want, I think these are nice features. :3
Sakura
osu! Alumni
7,979 posts
Joined March 2010
Sakura
Nice improvement there, need to try it out
blissfulyoshi
osu! Alumni
4,755 posts
Joined July 2008
blissfulyoshi
Yay sb!
I haven't got a chance to check to test the sb stuff yet, but I noticed that the AIBat does not test to see if you have a preview point or not ( previewPoint != -1)

I guess I will do some more testing soon to see what else I find. Besides that, keep up the good work!
Ayeen_old
316 posts
Joined October 2010
Ayeen_old
Im suggesting add in score for each difficulty. Nowadays many mappers tend to have guest difficulty, and one of the issues arise from that is scoring spreadsheet messed up which like the score is very close even though the hardness is quite far gap or the harder difficulty is lower score than the less difficult beforehand
Sakura
osu! Alumni
7,979 posts
Joined March 2010
Sakura

Ayeen wrote:

Im suggesting add in score for each difficulty. Nowadays many mappers tend to have guest difficulty, and one of the issues arise from that is scoring spreadsheet messed up which like the score is very close even though the hardness is quite far gap or the harder difficulty is lower score than the less difficult beforehand
The problem with that is that scoring is based off star rating as well, and he already said he doesn't know the algorithm for star rating, let alone scoring algorithm
Ayeen_old
316 posts
Joined October 2010
Ayeen_old
Some map cant seem to be opened by the newest ver. The map that I talking about is Dj Taka Color Maybe you can pinpoint what actually causing it unable to open or it just my computer here
akrolsmir
606 posts
Joined November 2010
Topic Starter
akrolsmir
Thanks for all the comments so far!

blissfulyoshi wrote:

Yay sb!
I haven't got a chance to check to test the sb stuff yet, but I noticed that the AIBat does not test to see if you have a preview point or not ( previewPoint != -1)

I guess I will do some more testing soon to see what else I find. Besides that, keep up the good work!
Oh right. I remember considering that at some point, but it wasn't a particularly high priority since AIMod already checks for that. But since someone pointed it out, I guess I can throw that feature in.

Sakura Hana wrote:

Ayeen wrote:

Im suggesting add in score for each difficulty. Nowadays many mappers tend to have guest difficulty, and one of the issues arise from that is scoring spreadsheet messed up which like the score is very close even though the hardness is quite far gap or the harder difficulty is lower score than the less difficult beforehand
The problem with that is that scoring is based off star rating as well, and he already said he doesn't know the algorithm for star rating, let alone scoring algorithm
Yeah, it's partly that, and partly that it's something else that the osu! editor testplay mode will also show you. If someone ever gets me the algorithm and I can figure out how to properly use it, then I might include it, but it's not a high priority because that functionality is already available.

Ayeen wrote:

Some map cant seem to be opened by the newest ver. The map that I talking about is Dj Taka Color Maybe you can pinpoint what actually causing it unable to open or it just my computer here
(I remember modding that :P )
Oh, that's a known bug, caused by the fact that a timing point is located at a time that is not a whole number
[TimingPoints]
1428.91603239078,387.096774193548,4,1,0,60,1,0
It really ought to be 1429 for the offset, since I can't remember the last time 0.1 milliseconds made a difference. Personally I'm unsure why osu! editor allows times, x and y-locations to be decimals, but whenever that happens the program breaks. I'm working on a way to fix that (or at least some kind of notice about the errors in the .osu file)
blissfulyoshi
osu! Alumni
4,755 posts
Joined July 2008
blissfulyoshi
Another feature:
Check for consistent BPMs for uninherited timing sections (assuming the decimal numbers don't break things here...)

Small bugs:
pippidon and sliderb stuff come out as unused image files right now even though they are used (I am guessing this is not implemented yet, but I didn't see it on the changelog)
Ayeen_old
316 posts
Joined October 2010
Ayeen_old
Sorry for the 3rd post, I suggesting to pin out the slider speed underneath the inherited time as well

About the storyboard, it seem there an issue where it cant elaborate subfolder content. And some skin element that was used to be reported as "unused" as well. Though, i wont say that would be a big issue

Example:
This was used, but reported unused skin element
SPOILER
fail-background.png
pause-overlay.png
star2.png

Example:
It reported missing, but actually it was used in SB
SPOILER
***Missing SB Files***
SB\fly.png
SB\beatmap.png
SB\star.png
SB\mduh.png
SB\storyboard.png
SB\black.png
SB\BG.png
SB\fly2.png
SB\and.png

Bleh ninjaed by Bliss :|

Edit: thinking about what Bliss said, maybe you can add in some unherited timing that was used for metronome reset too.
akrolsmir
606 posts
Joined November 2010
Topic Starter
akrolsmir

blissfulyoshi wrote:

Another feature:
Check for consistent BPMs for uninherited timing sections (assuming the decimal numbers don't break things here...)

Ayeen wrote:

Edit: thinking about what Bliss said, maybe you can add in some unherited timing that was used for metronome reset too.
So, if I understand everything correctly, you guys mean that an uninherited timing section should have a different BPM from the timing section before it, unless it was used for a metronome reset. How about a warning that says goes like:

"01:23:456 - This red timing section has the same BPM as the one before it; use a green timing point instead if this was not done for a metronome reset."

That's kind of long, though; can anyone think of a shorter message?

blissfulyoshi wrote:

Small bugs:
pippidon and sliderb stuff come out as unused image files right now even though they are used (I am guessing this is not implemented yet, but I didn't see it on the changelog)
Oh, I see. I relied on the listing under "FAQ > Map Design Issues > Missing/Unnecessary files in the package" for which files to consider skin files, but I guess that listing misses out on others. I'll put the other ones in the next update, based on what's in the default skin template- I hope that's comprehensive.

Ayeen wrote:

Sorry for the 3rd post, I suggesting to pin out the slider speed underneath the inherited time as well
No problem! I'm always happy to receive more feedback. Though I'm not sure what you mean by this suggestion, could you elaborate on that?

Ayeen wrote:

About the storyboard, it seem there an issue where it cant elaborate subfolder content. And some skin element that was used to be reported as "unused" as well. Though, i wont say that would be a big issue

Example:
This was used, but reported unused skin element
SPOILER
fail-background.png
pause-overlay.png
star2.png

Example:
It reported missing, but actually it was used in SB
SPOILER
***Missing SB Files***
SB\fly.png
SB\beatmap.png
SB\star.png
SB\mduh.png
SB\storyboard.png
SB\black.png
SB\BG.png
SB\fly2.png
SB\and.png

Bleh ninjaed by Bliss :|
His name's Bliss and not Yoshi?

The unused images thing is a known problem- see my reply to Yoshi's Bliss's statement above. The second one, though, should not be happening- could you link me to the folder that causes the problem?
Ayeen_old
316 posts
Joined October 2010
Ayeen_old
Slider speed I mean there was inherited timing like 0.75, 0.5,0.6 and so on. This is for map that are using more than 3 setup specifically. Though, I think this one can be easily notice via playing the map itself.

Well for the SB files missing:

Pit a pat Summer Where the SB folder is inside the song folder just like common SB files always. I think it be more complicated when there is another folder inside the "SB" folder like lyrics folder.
blissfulyoshi
osu! Alumni
4,755 posts
Joined July 2008
blissfulyoshi
Oh sorry for being vague, I was not talking about metronome switches (in fact those are fine). I was talking about consistent BPMs across diffs because sometimes a mapper forgets to change the BPM on all diffs when changing timing sections (very rare, but oh well)

About how to call me, yoshi is fine. The reason a lot of ppl use bliss is because there are multiple yoshis, but feel free to use whatever you want.
akrolsmir
606 posts
Joined November 2010
Topic Starter
akrolsmir

Ayeen wrote:

Slider speed I mean there was inherited timing like 0.75, 0.5,0.6 and so on. This is for map that are using more than 3 setup specifically. Though, I think this one can be easily notice via playing the map itself.
Good idea, added onto todo list.

Ayeen wrote:

Well for the SB files missing:

Pit a pat Summer Where the SB folder is inside the song folder just like common SB files always. I think it be more complicated when there is another folder inside the "SB" folder like lyrics folder.
I see... the bug was caught and eliminated, should be good on the next release. (I mistakenly used the same HashSet for both unused images and all image names... not a good idea)

blissfulyoshi wrote:

Oh sorry for being vague, I was not talking about metronome switches (in fact those are fine). I was talking about consistent BPMs across diffs because sometimes a mapper forgets to change the BPM on all diffs when changing timing sections (very rare, but oh well)

About how to call me, yoshi is fine. The reason a lot of ppl use bliss is because there are multiple yoshis, but feel free to use whatever you want.
Well, that actually makes a lot of sense- so much so that I had assumed I already programmed it that way. Turns out I didn't, but that's fixed now. Here's what the output under Timing Sections looks like now:

AIBat Warnings
These warnings were generated by AIBat.

Timing Sections:
Inconsistency in uninherited (red) timing sections:
- [Hard]
Red timing sections at:
00:00:536, BPM of 93.450

- [Test]
Red timing sections at:
00:00:536, BPM of 93.458
blissfulyoshi
osu! Alumni
4,755 posts
Joined July 2008
blissfulyoshi
Oh yeah, this was a strange scenario. If you add a word under [Colours], (during the mod he had [Colours] printed twice), AIBat says the combo colors are inconsistent even though all of them were exactly the same. (It took me a while to realize what the issue was, but I severely doubt that this will happen very often)
Ayeen_old
316 posts
Joined October 2010
Ayeen_old
New update, I see. Been away these few days, should see what new
Card N'FoRcE
osu! Alumni
4,058 posts
Here since the beginning
Card N'FoRcE
I swear that i can't get AIBat to work °°

I got the jar application, i run it and choose the beatmap folder.
After that i don't get anything else., whatever folder i choose it doesn't work.

I'm using Windows 7. If this helps, I have osu! sotred in a external drive, but i don't think it should be an issue °°
ziin
2,632 posts
Joined January 2010
ziin
Update java, make sure you don't put aibat in the actual osu folder (I couldn't run it in any folder which had a ! in the path).
Card N'FoRcE
osu! Alumni
4,058 posts
Here since the beginning
Card N'FoRcE
Java is updated, and AIbat is in my desktop and runs correctly, it just doesn't do anything after i choose the folder (and press Enter)

I suspect it may be something about Admin rights, but how can i run the Java console without opening the .jar? @_@
ziin
2,632 posts
Joined January 2010
ziin
if it's admin rights, then run it as administrator.
Card N'FoRcE
osu! Alumni
4,058 posts
Here since the beginning
Card N'FoRcE
.jar aren't executable files, they can't be run with admin rights by the context menu.
ziin
2,632 posts
Joined January 2010
ziin
Certainly they can be run via command line, or with a shortcut, or under the "properties" menu?
akrolsmir
606 posts
Joined November 2010
Topic Starter
akrolsmir
Nothing for 3 days, and then 8 comments in 12 hours...

blissfulyoshi wrote:

Oh yeah, this was a strange scenario. If you add a word under [Colours], (during the mod he had [Colours] printed twice), AIBat says the combo colors are inconsistent even though all of them were exactly the same. (It took me a while to realize what the issue was, but I severely doubt that this will happen very often)
That would make sense, since the program is configured to check from the first instance of "[Colours]" to the first instance of "[Hitobjects]". I think the bigger question is how the mapper managed to get 2 lines of that in the first place :|

ziin wrote:

Update java, make sure you don't put aibat in the actual osu folder (I couldn't run it in any folder which had a ! in the path).
Yeah, this problem isn't just for AIBat but comes up for all .jar's in any folder that has a "!" as the last character in the filename. Weird glitch or something, but I don't think it's something I can fix.

Card N'FoRcE wrote:

I swear that i can't get AIBat to work °°

I got the jar application, i run it and choose the beatmap folder.
After that i don't get anything else., whatever folder i choose it doesn't work.

I'm using Windows 7. If this helps, I have osu! sotred in a external drive, but i don't think it should be an issue °°
I'm using Windows 7 too (64 bit). Hm... to try and control for other variables, try unzipping this test folder and putting it on your desktop, and trying to open that with AIBat. If that works then it probably has something to do with the external drive, if not then probably admin privileges. Additionally, what happens after you press the "Enter" button? Does the program freeze up (i.e. you can't click on anything/select any other folders) or just not respond?

Also, on the off chance this works, try opening folders with the direct open function (ctrl+O, or File>Open). Shouldn't make a difference but might as well give it a shot.
blissfulyoshi
osu! Alumni
4,755 posts
Joined July 2008
blissfulyoshi
Another suggestion: Give a warning if the preview time + the time difference between the start of the song and the first note is less than 1s. This is to make sure the preview time is long enough.

Bugs:
Pippidon is not checked
selection-mod-xxxxxx should not be in a map skin (they don't show up) (there are actually quite a few skin files don't affect maps that are currently allowed right now, let me see if I can find a comprehensive list)

Taiko code printout for reference:
SPOILER
***Unused Image Files***
pippidonkiai3.png
pippidonkiai1.png
pippidonidle3.png
pippidonidle0.png
pippidonidle2.png
pippidonclear3.png
pippidonclear0.png
pippidonkiai0.png
pippidonclear6.png
pippidonclear1.png
pippidonfail0.png
pippidonfail1.png
pippidonclear4.png
pippidonidle1.png
pippidonclear2.png
pippidonkiai2.png
pippidonclear5.png

As for what conditions I am running AIBat: Windows 7 (x64) with Java version 6 update 24 with both runtime and SDK
Card N'FoRcE
osu! Alumni
4,058 posts
Here since the beginning
Card N'FoRcE

akrolsmir wrote:

I'm using Windows 7 too (64 bit). Hm... to try and control for other variables, try unzipping this test folder and putting it on your desktop, and trying to open that with AIBat. If that works then it probably has something to do with the external drive, if not then probably admin privileges. Additionally, what happens after you press the "Enter" button? Does the program freeze up (i.e. you can't click on anything/select any other folders) or just not respond?

Also, on the off chance this works, try opening folders with the direct open function (ctrl+O, or File>Open). Shouldn't make a difference but might as well give it a shot.
I already tried everything you said here: i tried opening the folder by both CTRL-O and manual folder selection, but when i press Enter it just does nothing °°
The program doesn't freeze up when i press Enter, it just doesn't analyze the folder whatever the path is (even C:\AAAA).
I tried having a look at admin rights, but i basically have everything allowed already and UAC is disabled. I also removed some kind of "lock" under Properties because this is a downloaded file.

I dunno what else to do xD
Sakura
osu! Alumni
7,979 posts
Joined March 2010
Sakura
yeah im at a loss here about your problem too CnF i use win 7 as well and i have no problems X_X (wonder if you need the latest jdk too?)
blissfulyoshi
osu! Alumni
4,755 posts
Joined July 2008
blissfulyoshi
I started thinking about bitrate again, and probably the best way to check the bitrate is to use the equation (The size of the mp3 in bytes) * 8 / (the length of the song in seconds) / (1000) = kbps of the mp3 + size of tags/metadata/etc. Since the metadata is usually very small, the calculated bitrate tends to run out only 1kbps larger than normal, so if you use the equation above and say only set off the error if the bitrate is greater than 196, it is probably fine.

Other things I noticed about bitrate:
You need to be able to check vbr and cbr (there are others, but these 2 are the most open)
The most accurate way to check the average bitrate is to constantly measure the bitrate of the song at every instance and add them up (basically a giant integral , several thousand parts per second is close enough to an integral for me). Afterward divide the entire number by the length of the song, and you will get the final number
Doing the above method is incredibly difficult.
akrolsmir
606 posts
Joined November 2010
Topic Starter
akrolsmir
New releases will probably come less frequently (bimonthly or so instead of biweekly) now that my internship for this summer is starting, but keep commenting! I still read and think about everything that is posted here.

To look forward to in the next release: Bookmarking folders, and a search function!

blissfulyoshi wrote:

Another suggestion: Give a warning if the preview time + the time difference between the start of the song and the first note is less than 1s. This is to make sure the preview time is long enough.
I spent ten minutes trying to understand this part... did you mean AudioLeadIn? If so, that's a good suggestion, but is 1 sec long enough?

blissfulyoshi wrote:

Bugs:
Pippidon is not checked
selection-mod-xxxxxx should not be in a map skin (they don't show up) (there are actually quite a few skin files don't affect maps that are currently allowed right now, let me see if I can find a comprehensive list)

Taiko code printout for reference:
Is Pippidon limited to exactly those frames, or can the animation be changed at will? (If it's the latter I'll have to implement that after I understand and properly account for SB animations. Which I should do anyways.)

I left in selection-mod-xxxx and other similar files so that AIBat could be used to check skins as well beatmaps, but I guess that could cause problems with the overlap (i.e. someone accidentally includes a selection-mod-taiko in their beatmap folder and AIBat doesn't catch it). Perhaps I'll just create a short skin checker later and release it seperately.

And the method for calculating bitrate seems great, the only thing stopping me is finding the length of an mp3 file (still). I've found a few references online and I'll try it sometime, but it won't be in the next release.

Card N'FoRcE wrote:

I already tried everything you said here: i tried opening the folder by both CTRL-O and manual folder selection, but when i press Enter it just does nothing °°
The program doesn't freeze up when i press Enter, it just doesn't analyze the folder whatever the path is (even C:\AAAA).
I tried having a look at admin rights, but i basically have everything allowed already and UAC is disabled. I also removed some kind of "lock" under Properties because this is a downloaded file.

I dunno what else to do xD
My guess is that Java somehow is denied access to reading files on your computer- that's the only reason I can think of for the window to open and yet not be able to open beatmaps. When I get some more spare time I'll try porting it to .exe to see if it makes a difference, but in the meantime you could try downloading eclipse and compiling the code yourself :P . I'm really sorry it doesn't work for you, if there are any maps you'd like to check you can always PM me and I'll send AIBat's results to you.
Zekira
9,233 posts
Joined September 2008
Zekira
No, this won't automatically rank your beatmaps
Sorry but this statement is still making me smile lololol
ziin
2,632 posts
Joined January 2010
ziin

akrolsmir wrote:

I spent ten minutes trying to understand this part... did you mean AudioLeadIn? If so, that's a good suggestion, but is 1 sec long enough?
If AudioLeadIn + First note < 1500, output an error. It's more of an error check to make sure that you don't forget an AudioLeadIn if you need it.

akrolsmir wrote:

I left in selection-mod-xxxx and other similar files so that AIBat could be used to check skins as well beatmaps, but I guess that could cause problems with the overlap (i.e. someone accidentally includes a selection-mod-taiko in their beatmap folder and AIBat doesn't catch it). Perhaps I'll just create a short skin checker later and release it seperately.
Add in a "skin mode". Or add the skin specific stuff (like fruit-plate, selection mods, and circle highlight) in a "skin" tab, and apply its own custom skinset (like how hitcircle, hitcircleoverlay, and approach circle have to be together). If someone has a skin specific file in the beatmap, treat it like a skin, and put a notice at the top saying "if this is not a skin, you have an unnecessary skin file in your map and should remove it".

akrolsmir wrote:

And the method for calculating bitrate seems great, the only thing stopping me is finding the length of an mp3 file (still).
You can try reading the id3 tag, but the best way is to figure out the song duration.
And: http://stackoverflow.com/questions/3046 ... me-in-java

Also, I'm not sure which skin elements you check, but these are the important ones:
approachcircle
hitcircle
hitcircleoverlay
cursor
hit0 etc...

Questionable:
fruits

One thing you can do is check each and make a note that "X" is (much) bigger than the template skin dimensions.
blissfulyoshi
osu! Alumni
4,755 posts
Joined July 2008
blissfulyoshi

akrolsmir wrote:

blissfulyoshi wrote:

Another suggestion: Give a warning if the preview time + the time difference between the start of the song and the first note is less than 1s. This is to make sure the preview time is long enough.
I spent ten minutes trying to understand this part... did you mean AudioLeadIn? If so, that's a good suggestion, but is 1 sec long enough?
Yeah...Audio lead-in. Not sure about the time 1-1.5 seconds is probably enough though.

blissfulyoshi wrote:

Bugs:
Pippidon is not checked
selection-mod-xxxxxx should not be in a map skin (they don't show up) (there are actually quite a few skin files don't affect maps that are currently allowed right now, let me see if I can find a comprehensive list)

Taiko code printout for reference:
Is Pippidon limited to exactly those frames, or can the animation be changed at will? (If it's the latter I'll have to implement that after I understand and properly account for SB animations. Which I should do anyways.) Sorry not sure about the details about the frames. I guess for now, just allow all frames.
Sakura
osu! Alumni
7,979 posts
Joined March 2010
Sakura
Audio Lead-in wise i think 1.5 - 2 seconds before the approach circle appears is fine enough, however that would need a human modder probably (unless you can calculate time with approach rate), so i'd say 2 seconds until the first note should be enough, any less and throw a warning
blissfulyoshi
osu! Alumni
4,755 posts
Joined July 2008
blissfulyoshi
I forgot if this was reported already, but it seems that .png files inside a folder aren't reported correctly.
SPOILER

Also, if some but not all of the kiai timings match up exactly in every diff, could you not post them. (so if only one kiai section is inconsistent among all the diffs, could you only post that one section?)

Bug: AIBat suggest there should be an epilepsy warning even if epilepsy warning is on.
Lybydose
osu! Alumni
2,024 posts
Joined January 2009
Lybydose
- Checks for snapping in inherited points
Why does this matter? The only green sections that need to be snapped are those that start kiai and those that end kiai, and even end kiai is questionable.

blissfulyoshi wrote:

selection-mod-xxxxxx should not be in a map skin (they don't show up) (there are actually quite a few skin files don't affect maps that are currently allowed right now, let me see if I can find a comprehensive list)
Actually technically they do for a few seconds:

http://osu.ppy.sh/ss/107141

but they still probably shouldn't be included.
Sakura
osu! Alumni
7,979 posts
Joined March 2010
Sakura

Lybydose wrote:

- Checks for snapping in inherited points
Why does this matter? The only green sections that need to be snapped are those that start kiai and those that end kiai, and even end kiai is questionable.
It doesnt matter yeah, however it's good to know which ones are unsnapped, because if they are unsnapped AHEAD of a note, then we may have a hitsound problem since for it to affect it it needs to be on the note or before, otherwise it doesnt matter besides kiai really.
Lybydose
osu! Alumni
2,024 posts
Joined January 2009
Lybydose
You should check that by listening to the song/map.
akrolsmir
606 posts
Joined November 2010
Topic Starter
akrolsmir

ziin wrote:

Add in a "skin mode". Or add the skin specific stuff (like fruit-plate, selection mods, and circle highlight) in a "skin" tab, and apply its own custom skinset (like how hitcircle, hitcircleoverlay, and approach circle have to be together). If someone has a skin specific file in the beatmap, treat it like a skin, and put a notice at the top saying "if this is not a skin, you have an unnecessary skin file in your map and should remove it".
... I always miss the obvious, practical solutions.

ziin wrote:

You can try reading the id3 tag, but the best way is to figure out the song duration.
And: http://stackoverflow.com/questions/3046 ... me-in-java
Alright, from there I found a magical library that gets the bitrate directly for me; I might not even need song duration anymore! Also, does anyone have an mp3 file with a Variable Bit Rate and a known average to provide me for testing the bitrate that the library give me?

ziin wrote:

Also, I'm not sure which skin elements you check, but these are the important ones:
approachcircle
hitcircle
hitcircleoverlay
cursor
hit0 etc...

Questionable:
fruits

One thing you can do is check each and make a note that "X" is (much) bigger than the template skin dimensions.
You could try digging through the source code, it should be understandable. Maybe ;) . Anyways, currently they are:
hitcircle, approachcircle, hitcircle overlay must all be 128x128
hit0... to hit300g must be 256x256
spinnercircle must be 666x666
pauseoverlay, playfield must be 1024x768
comboburst must be less than 500x767

I guess I'm missing cursor and fruits, what are the dimensions for those?

Sakura Hana wrote:

Audio Lead-in wise i think 1.5 - 2 seconds before the approach circle appears is fine enough, however that would need a human modder probably (unless you can calculate time with approach rate), so i'd say 2 seconds until the first note should be enough, any less and throw a warning
Alright, I think a warning for under 2 seconds would be good, and perhaps a stronger one if it's under 1?

blissfulyoshi wrote:

I forgot if this was reported already, but it seems that .png files inside a folder aren't reported correctly.
... tried to use != instead of !.equals() on a string. Anyways, it should be fixed now.

blissfulyoshi wrote:

Also, if some but not all of the kiai timings match up exactly in every diff, could you not post them. (so if only one kiai section is inconsistent among all the diffs, could you only post that one section?)
Aww... that would involve changing how Kiai is checked- I was lazy and just compared the entire thing as strings, which was easier. Which is probably bad coding. Put under TODO.

blissfulyoshi wrote:

Bug: AIBat suggest there should be an epilepsy warning even if epilepsy warning is on.
I couldn't reproduce this, could you tell me which folder you were using when this happened?

Lybydose wrote:

Why does this matter? The only green sections that need to be snapped are those that start kiai and those that end kiai, and even end kiai is questionable.
Yeah, I've heard that. Besides what Sakura said, I just kind of like maps to be nice and neat and snapped (I once popped a bubble to fix one of my maps in that regard). If other's don't care about such things and don't want to change it they can just ignore those warnings, I guess.
[Kanzaki Ranko]
327 posts
Joined June 2009
[Kanzaki Ranko]
File length is filesize divided by bitrate.
Hope that helps.

Edit:
True for both ogg and mp3.
blissfulyoshi
osu! Alumni
4,755 posts
Joined July 2008
blissfulyoshi

akrolsmir wrote:

Alright, from there I found a magical library that gets the bitrate directly for me; I might not even need song duration anymore! Also, does anyone have an mp3 file with a Variable Bit Rate and a known average to provide me for testing the bitrate that the library give me? Yay, let's use my map. http://osu.ppy.sh/s/32318 Bitrate is in the metadata (164kbps). More exactly, It is probably somewhere between 164-165.

blissfulyoshi wrote:

Bug: AIBat suggest there should be an epilepsy warning even if epilepsy warning is on.
I couldn't reproduce this, could you tell me which folder you were using when this happened?
As for this, I was checking http://osu.ppy.sh/s/26860, and if you look in the file, the epilepsy warning is on, but it warned me anyway. (Reminder: you can only see the visual effect of the epilepsy warning when playing standard, not through the editor)
akrolsmir
606 posts
Joined November 2010
Topic Starter
akrolsmir
ARGGGH I'm gone for 30 hours and pages upon pages of new ranking criteria are put up...

Anyone know if peppy is planning on updating AIMod to reflect these new guidelines? If so, I might drop AIBat or rework it to include less overlap. It's not that I mind working on it, I just don't want to waste my effort on duplicating functionality.

Maav wrote:

File length is filesize divided by bitrate.
Hope that helps.

Edit:
True for both ogg and mp3.
I kind of already knew that, but thanks for your contribution. Thankfully the magical library I mentioned earlier finds both for me, directly :) .

blissfulyoshi wrote:

Yay, let's use my map. http://osu.ppy.sh/s/32318 Bitrate is in the metadata (164kbps). More exactly, It is probably somewhere between 164-165.
Cool, the check returned 164 as well. I guess that means I'll be implementing the bitrate check very soon.

blissfulyoshi wrote:

As for this, I was checking http://osu.ppy.sh/s/26860, and if you look in the file, the epilepsy warning is on, but it warned me anyway. (Reminder: you can only see the visual effect of the epilepsy warning when playing standard, not through the editor)
Thanks for the sample map! I've caught and fixed the bug- I forgot to account for the space in between "Epilepsy Warning:" and "1".
Equivalent_old
210 posts
Joined October 2010
Equivalent_old
Minor bug:
Hitcircle.png not reported missing even if none in beatmap as the other elements of hitcirles are there.
blissfulyoshi
osu! Alumni
4,755 posts
Joined July 2008
blissfulyoshi

akrolsmir wrote:

Anyone know if peppy is planning on updating AIMod to reflect these new guidelines? If so, I might drop AIBat or rework it to include less overlap. It's not that I mind working on it, I just don't want to waste my effort on duplicating functionality.
About the new guidelines, it seems there needs to be a fair amount of discussion before those are finished and in addition AIMod is fairly low on the priority list, so I wouldn't worry too much AIMod having duplicate functionality.
akrolsmir
606 posts
Joined November 2010
Topic Starter
akrolsmir

Equivalent wrote:

Minor bug:
Hitcircle.png not reported missing even if none in beatmap as the other elements of hitcirles are there.
Hm... could you provide a sample folder for me to look at? Thanks!

blissfulyoshi wrote:

About the new guidelines, it seems there needs to be a fair amount of discussion before those are finished and in addition AIMod is fairly low on the priority list, so I wouldn't worry too much AIMod having duplicate functionality.
Ah, okay. I'll primarily be focusing on adding checks in the next iteration, since I've already implemented most of the features I wanted to. I guess I can start looking through the suggested new guidelines and putting checks for those as well. Thanks for the update!
Pereira006
osu! Alumni
2,801 posts
Joined October 2010
Pereira006
Hello

I have question here

I just feeling problem aibat or i wrong

Aibat is working my pc ok but sometime i click folder will not show nothing
I just test aibat and i click folder from my map but still not show and i remove diff insane, normal now Aibat is working and show all. So i put again normal and insane and remove hard now aibat is not working again

I just test another folder map is same problem

I can't understand very well what problem Aibat...
Sometime Aibat is not working somehere diff...
or I wrong? :(

i use Windows XP SP3

and sorry my bad english
Sakura
osu! Alumni
7,979 posts
Joined March 2010
Sakura
Probably you should include a link to the beatmap/osz in question so he can work it out and see what's the problem so he can fix it
lolcubes
osu! Alumni
4,437 posts
Joined November 2010
lolcubes
From what I remember in earlier testing, you can't check mapsets which have empty maps. So for example, if you have a normal diff which is completely empty without a note, you won't be able to open the mapset at all. I haven't tested the latest version yet though.
akrolsmir
606 posts
Joined November 2010
Topic Starter
akrolsmir

Pereira006 wrote:

Hello

I have question here

I just feeling problem aibat or i wrong

Aibat is working my pc ok but sometime i click folder will not show nothing
I just test aibat and i click folder from my map but still not show and i remove diff insane, normal now Aibat is working and show all. So i put again normal and insane and remove hard now aibat is not working again

I just test another folder map is same problem

I can't understand very well what problem Aibat...
Sometime Aibat is not working somehere diff...
or I wrong? :(

i use Windows XP SP3

and sorry my bad english

Sakura Hana wrote:

Probably you should include a link to the beatmap/osz in question so he can work it out and see what's the problem so he can fix it
Yes, that would be very helpful, since it sounds like AIBat is only breaking on certain maps, not everything (Like it does for CnF)

I also quickly looked through your pending maps, but none of them were Normal/Hard/Insane, so I didn't try and download all of them. "Call Girl" worked fine, though.

lolcubes wrote:

From what I remember in earlier testing, you can't check mapsets which have empty maps. So for example, if you have a normal diff which is completely empty without a note, you won't be able to open the mapset at all. I haven't tested the latest version yet though.
That's true, and hasn't really been fixed yet, so it's possibly the cause. I should probably make AIBat throw out a notice about that if it ever happens.
blissfulyoshi
osu! Alumni
4,755 posts
Joined July 2008
blissfulyoshi
Feature Request xD:
Check to make sure there are no timing sections at the same point in time, unless the timing section is there to change the slider speed. (If you are lazy, you can just check to see if there are timing sections with the same offset xD)
Equivalent_old
210 posts
Joined October 2010
Equivalent_old

blissfulyoshi wrote:

Feature Request xD:
Check to make sure there are no timing sections at the same point in time, unless the timing section is there to change the slider speed. (If you are lazy, you can just check to see if there are timing sections with the same offset xD)
Im pretty much guessing Bliss mean inherited time and unherited time on the same spot. It is rarely oocurs, if it only 1 offset maybe it easier to check without this app, but what if it got like 20 redlines? A good features I say
blissfulyoshi
osu! Alumni
4,755 posts
Joined July 2008
blissfulyoshi

Equivalent wrote:

blissfulyoshi wrote:

Feature Request xD:
Check to make sure there are no timing sections at the same point in time, unless the timing section is there to change the slider speed. (If you are lazy, you can just check to see if there are timing sections with the same offset xD)
Im pretty much guessing Bliss mean inherited time and unherited time on the same spot. It is rarely oocurs, if it only 1 offset maybe it easier to check without this app, but what if it got like 20 redlines? A good features I say
Well sometimes ppl put 2 uninherited sections at the same time (usually by accident....), so I want to avoid that from happening. Besides, of couse I want to prevent silly things like 2 inherited sections at the same time too.
Zhanger_old
Zhanger_old
just wondering-- could you release the source for beatmap url formatter and the osudistancechecker as well? Just curious P:

also --
This would allow you to read the page source for your beatmap url formatter therefore speeding up the process :3

package javaapplication4;
import java.io.BufferedReader;
import java.io.InputStreamReader;
import java.net.URL;


/**
 *
 * @author Alex
 */
public class WebRetrieve {
    public static void main(String[] args) {
        try {
            URL url = new URL("http://osu.ppy.sh/p/beatmaplist");
            BufferedReader br = new BufferedReader(new InputStreamReader(url.openConnection().getInputStream()));
            String thisline = "";
            while((thisline = br.readLine()) != null) {
                System.out.println(thisline);
            }
br.close();
        } catch (Exception ex) {
            System.err.println(ex);
        }
    }

}
ziin
2,632 posts
Joined January 2010
ziin
a few suggestions:

I'm starting to include an AIBat post in my mods. If possible could you do this stuff:

Put the version number of AIBat in the first line (ie generated by AIBat 0.6b)
Also include an explanation at the top of what the program does. "This program generates warnings based on the current ranking guidelines and rules. Things like breaks and spinners can be usually ignored, but just know that it's generally a bad practice."
Breakless songs are all over the place and get ranked just fine, and someone who doesn't know what AIBat is may get the wrong message. Perhaps change the wording?
The spinners are okay (it's good to know how long they actually are), but perhaps an explanation of "if this spinner doesn't get 2000 on auto, it is too short"
If no problems found or not implemented yet, don't copy to clipboard.
only put two line breaks maximum next to each other. (so there's only 1 empty line)
Just put a mention saying: "Combo colors are inconsistent. Please double check your combo colors or run AIBat yourself to see."
Could do background color too, but I don't think anyone sees that anymore.

And as for coding this in java, I don't think there's a problem I rather like having separate programs from osu since you can't have 2 osu windows open.
Sakura
osu! Alumni
7,979 posts
Joined March 2010
Sakura
This is becoming a quite helpful tool, it helps me save a lot of time, keep it up!
akrolsmir
606 posts
Joined November 2010
Topic Starter
akrolsmir

blissfulyoshi wrote:

Equivalent wrote:

Im pretty much guessing Bliss mean inherited time and unherited time on the same spot. It is rarely oocurs, if it only 1 offset maybe it easier to check without this app, but what if it got like 20 redlines? A good features I say
Well sometimes ppl put 2 uninherited sections at the same time (usually by accident....), so I want to avoid that from happening. Besides, of couse I want to prevent silly things like 2 inherited sections at the same time too.
It'd probably be relatively easy to configure this as checking for any two sections that are within, say, 5 ms of each other. Good idea, I'll work on it!

Zhanger wrote:

just wondering-- could you release the source for beatmap url formatter and the osudistancechecker as well? Just curious P:

also --
This would allow you to read the page source for your beatmap url formatter therefore speeding up the process :3
Released, and thanks for this code! (I had no idea reading online stuff was that easy o.O) Don't know if I'll update beatmap url formatter yet, since I think AIBat has a lot more utility and potential as of right now. Also, if someone can find something really useful to do by reading the source code of osu! pages, I'd be glad to try and implement it.

ziin wrote:

a few suggestions:

I'm starting to include an AIBat post in my mods. If possible could you do this stuff:

*Stuff*

And as for coding this in java, I don't think there's a problem I rather like having separate programs from osu since you can't have 2 osu windows open.
Thanks! These are good suggestions, and I really appreciate feedback about the layout and how to improve usage- I find that I spend as much time on that as getting the program to work in the first place.

And about java- perhaps, one day, should the program be deemed helpful enough, coding it in C# might have it merit integration with osu! editor, kind of like AIMod currently. /endpipedream

Sakura Hana wrote:

This is becoming a quite helpful tool, it helps me save a lot of time, keep it up!
Glad it's being used! Development is slowing down since it's implemented most of the interesting-to-code features I wanted (e.g. searching), and putting in checks isn't as fun, not to mention working full-time hours for the first time ever :o . Hearing that it helps people keeps me working at it, though, so thank you for the encouragement!
blissfulyoshi
osu! Alumni
4,755 posts
Joined July 2008
blissfulyoshi
Just wondering, why are the missing skinned files posted in some random order?
Example: (you should probably make all comboburst-# not come up in the search)
[Storyboard]
Unused Image Files:
comboburst-1.png
comboburst-5.png
comboburst-3.png
comboburst-0.png
comboburst-2.png
comboburst-4.png
It would be nice if you put them in alphabetical/numerical order.
ziin
2,632 posts
Joined January 2010
ziin
If you feel like doing me a huge favor (and I'll mod as many maps as you want me to)

Make a program which exports hitsounds to bookmark format, one set for whistles, one for finishes, etc...

I requested it here but there's probably no reason it can't be done with ease in a separate utility.
Zhanger_old
Zhanger_old
next feature request - custom user scripts :D
utilizing the mozilla rhino javascript engine already pre-packaged with JDK, it'd probably be easy to implement
Here's from one afternoon of experimenting --
package javaapplication4;

import javax.script.*;
import java.io.*;

/**
 *
 * @author Alex
 */
public class scripttest {

    static ScriptEngineManager mgr = new ScriptEngineManager();
    public static void main(String[] args) {
        try {
            scriptexec();
        } catch (ScriptException ex) {
            ex.printStackTrace();
        }
    }
        static void scriptexec() throws ScriptException {
        ScriptEngine se = mgr.getEngineByName("javascript");
        se.eval("println('hello world');");
    }
}
Sakura
osu! Alumni
7,979 posts
Joined March 2010
Sakura


Actually the recommended size is 800x600 and the maximum rankable size is 1024x768
blissfulyoshi
osu! Alumni
4,755 posts
Joined July 2008
blissfulyoshi
Wow the thread has been inactive.
A few more feature request: Warn if a note is before the initial offset
Warn if a there is an inherited timing section right after a red section without any notes inbetween them
Sakura
osu! Alumni
7,979 posts
Joined March 2010
Sakura
Another nice addition would be if it warned about kiai start not being snapped to a long white tick.

Also some spelling correction "A sideboard has been detected" -> "A Storyboard has been detected"
Equivalent_old
210 posts
Joined October 2010
Equivalent_old
Inconsistency in Tags:
- [Easy Style] : r300k TOMIX Android Gamevil Natteke
- [Hard Style] : r300k Android TOMIX Gamevil Natteke
- [Natteke Style] : r300k Android TOMIX Gamevil Natteke
- [Normal Style] : r300k TOMIX Android Gamevil Natteke

Maybe you can address out this issue above, I mean like as long they are the same thing, it doesnt need to be pointed out. It quite small issue actually.
akrolsmir
606 posts
Joined November 2010
Topic Starter
akrolsmir

Sakura Hana wrote:

Also some spelling correction "A sideboard has been detected" -> "A Storyboard has been detected"
Lol. That's what I always think "SB" stands for. I guess I play too much Magic: the Gathering...

Thanks to everyone else for continuing to post suggestions and bugs here! After this internship wraps up this week (and I get back from a 3-day vacation immediately after), I'll have time to code up a lot of these features in AIBat. Also, with the next release will come an "Export hitsound" function that was requested by ziin. I guess I'll post a link here for that modification since I've already coded it-

AIBat v0.6.1
ziin
2,632 posts
Joined January 2010
ziin
that made my life so much easier for all of my beatmaps. I should probably double check blythe with it...
Sakura
osu! Alumni
7,979 posts
Joined March 2010
Sakura
Just here to say that i would like a Refresh feature if possible, so when for example rechecking the same map on AIBat i can just for example hit F5 and it rechecks it, another thing, put a warning when you're trying to exit, there's been plenty of times when i accidentally close AIBat after checking something like i close the AIMod window after checking it ._.

Edit: Also make it start at the top of the page, not the bottom ._.
akrolsmir
606 posts
Joined November 2010
Topic Starter
akrolsmir
Finally updated after a month or so. I'm still looking for new directions to take this, so feedback as always appreciated.

Also, if you have suggestions I'd love to hear them, and please rank them in order of importance so I know what people want the most :D .
ziin
2,632 posts
Joined January 2010
ziin
Highlight slider ends and circles which have a y<16 or y>368.

When points are above or below this, they run a high risk of being underneath the HP bar or off the screen, especially on easy/hard mod.

This number changes based on circle size, but as the majority of mapping uses circle size 4 it doesn't matter too much.

Acutally the numbers should be customizable. I can try to find out the exact limits if you want.

Examples:
Too low, off screen on easy mod
Fine with easy mod off
Sakura
osu! Alumni
7,979 posts
Joined March 2010
Sakura
I love how AIBat is starting to gain official recognition now like here and here keep up the good work Akrolsmir!!!
Lucy-Kaede
435 posts
Joined April 2011
Lucy-Kaede
Nice app!
One minor thing I noticed though, when checking my combo colours against a guest difficulty it listed them like this:
SPOILER
(AIBat) - (Osu! Editor)
Combo 1 - Combo 2
Combo 2 - Combo 3
Combo 3 - Combo 4
Combo 4 - Combo 1
akrolsmir
606 posts
Joined November 2010
Topic Starter
akrolsmir

Lucy-Kaede wrote:

Nice app!
One minor thing I noticed though, when checking my combo colours against a guest difficulty it listed them like this:
SPOILER
(AIBat) - (Osu! Editor)
Combo 1 - Combo 2
Combo 2 - Combo 3
Combo 3 - Combo 4
Combo 4 - Combo 1
Thanks for the feedback!
My hunch is that this is caused by the configuration of the .osu file. If you open that up, you'll see AIBat's listing is identical to how it is put in the actual .osu file, which can be different from what osu! Editor uses. As long as the actual colors are the same, the order shouldn't matter in terms of getting your map ranked, though.
ziin
2,632 posts
Joined January 2010
ziin
Since you managed to get hitsounds out of a map easily, would it be that difficult to put them back in? As in copy hitsounds in [insane] to [hard].
akrolsmir
606 posts
Joined November 2010
Topic Starter
akrolsmir

ziin wrote:

Since you managed to get hitsounds out of a map easily, would it be that difficult to put them back in? As in copy hitsounds in [insane] to [hard].
Reading files is easier than writing them, and both are easier than editing them. That said, I do like a challenge, so I'll consider it. Though, regarding its functionality: Mapping the hitsounds of circles, the ends/repeats of sliders, and the ends of spinners to a counterpart at a same time in a different diff is intuitive. If the hitobject has no counterpart I guess I'll just leave out the sound. What do I do with hitsounds for the entire slider, though?
------------------

On a non-AIBat related note, I've been thinking about a "Modding Companion", of sorts. The goal is to streamline the modding process. My idea was that you'd run the program for a beatmap you wanted to mod, and then proceed to make changes on that beatmap in osu! Editor. The program compares your modified .osu file to the original and displays any changes in a forum-friendly manner, giving a readout like:


[Hard]
01:21:456 - Add a circle
01:23:456 (7) - Add a whistle
01:24:456 (9) - Remove the circle
01:32:456 to 01:34:456 - Add a slider

And so on, only basic edits that are interpretable. The display is done in an editable window so you can also put in additional notes, other mods etc. When you're done, the program copies everything onto your clipboard so you can paste it in a forum, and also zips the edited osu files along with a second program that displays the entirety of the mod post as well as hyperlink-to-clipboard (like AIBat) for faster access to the notes. The idea here is that they can import your edited files into the beatmap directly in the Editor in parallel to the originals, and copy+paste the patterns they approve onto their file.

Is this something worth attempting? Would people use it?
Ekaru
3,617 posts
Joined July 2008
Ekaru

akrolsmir wrote:

Is this something worth attempting? Would people use it?
Yes, and yes. Do it.
ziin
2,632 posts
Joined January 2010
ziin
Actually peppy already made this program:

http://pe.ppy.sh/2009/06/265/


As far as hitsounds go:
when there is a hitsound on a slider, if threre is the 0|0|0|0|2 at the end, that means there is no hitsound except for a whistle on the last part of the repeat. The slider track may still have a hitsound where it is for regular circles, but the first four notes don't have any hitsound.

If there is a slider which starts on the same beat, you can copy the sliderslide hitsound, but if not, don't copy the hitsound and instead rely on the numbers at the end. If the slider has no numbers at the end and has a sliderslide hitsound, put that hitsound on each beat.

It's pretty confusing but I think you did a really good job with reading them.
Rei Hakurei
1,983 posts
Joined February 2011
Rei Hakurei
i've just tried this and i say thanks for first (cause AudioLeadIn inconsistency)..
(AIBat v0.7b)

but i've some thing that makes me feels strange..
1. Timing point offset should rounded?
AIBat
Timing Sections Inconsistency in uninherited (red) timing sections:
- [Easy] Red timing sections at: 00:01:602, BPM of 182.000
- [Final-Dream] Red timing sections at: 00:01:601, BPM of 182.371
Notepad
Final Dream: 1601.58650029137,329.67032967033,...
Easy: 1602,329.67032967033,...
same second per beat (329.6ms)[or beat per minute 182] and 1601.58 in osu! detected as 1602ms..

2. Storyboard File Case Sensitive?
Unused Image Files
SB\From_TouhouWiki_Untranslated\marisa_4.png
SB\marisakirisame_sweat_dialog4.png (this one is unused, i'll remove it later, thanks.)
SB\From_TouhouWiki_Untranslated\marisa_1.png
SB\From_TouhouWiki_Untranslated\reimu_5.png
comboburst-1.png
SB\From_TouhouWiki_Untranslated\reimu_3.png
SB\From_TouhouWiki_Untranslated\marisa_2.png
SB\From_TouhouWiki_Untranslated\marisa_6.png
comboburst-0.png
SB\From_TouhouWiki_Untranslated\reimu_4.png
SB\From_TouhouWiki_Untranslated\reimu_2.png
comboburst-2.png
comboburst-3.png
SB\From_TouhouWiki_Untranslated\marisa_3.png
SB\From_TouhouWiki_Untranslated\marisa_5.png
SB\From_TouhouWiki_Untranslated\reimu_1.png
Missing SB Elements
SB\From_TouhouWiki_UnTranslated\reimu_3.png
SB\From_TouhouWiki_UnTranslated\marisa_4.png
SB\From_TouhouWiki_UnTranslated\marisa_6.png
SB\From_TouhouWiki_UnTranslated\marisa_2.png
SB\From_TouhouWiki_UnTranslated\marisa_5.png
SB\From_TouhouWiki_UnTranslated\reimu_1.png
SB\From_TouhouWiki_UnTranslated\reimu_5.png
SB\From_TouhouWiki_UnTranslated\reimu_2.png
SB\From_TouhouWiki_UnTranslated\reimu_4.png
SB\From_TouhouWiki_UnTranslated\marisa_1.png
SB\From_TouhouWiki_UnTranslated\marisa_3.png
- should i replace the .osb file with case change?
- the skin file (comboburst-X.png) is used.

i'm sorry if i didn't read the previous page.
akrolsmir
606 posts
Joined November 2010
Topic Starter
akrolsmir
@Ekaru- Good to know there's a demand, thanks.

@ziin- Peppy's program doesn't seem tailored to modding, though. I'll think about what else I can do to make mine more distinguished from that, though.

And about hitsounds- I pretty much understand how hitsounds are assigned, I was just wondering about the best way to translate them between difficulties. What you suggested makes sense, I think. Also, should I clear existing hitsounds from the map first? Because adding the new hitsounds atop old ones seems like it would sound cacophonous.

@Rei_Fan49

Actually, as far as I can tell, osu! truncates those values instead of rounding them, so I choose to do the same in my program. Either way, I think that for your beatmap it'd be wisest just to set the offsets to 1602 exactly. Moreover, there's a difference in the BPM that should probably be addressed- set both values to 182.000?

About storyboarding- no, you probably don't need to fix anything if the osu! (or windows or whatever) file system ignores case when it comes to file names. Rather, I'll probably want to fix that in AIBat. Thanks for the report!

And the comboburst thing is a known issue based on the fact that I'm still trying to figure out what to do about file-1.png, file-2.png and so forth where AIBat just expects file.png.
Rei Hakurei
1,983 posts
Joined February 2011
Rei Hakurei
lol they are 182..
and also about the offset round or floor or truncate
SPOILER
osu! did both of them..
blissfulyoshi
osu! Alumni
4,755 posts
Joined July 2008
blissfulyoshi
Wow, I haven't replied in this thread for a while. Lets see what I can find now xD

Adding [Colours] after [Colours] is already staated once (I know you didn't fix this, but I wanted to recheck this): If my code is like
[Colours][Colours]
then I get 
 - [Easy] :
olours]
, but if my code is like 
[Colours]
[Colours]
then I get 
 - [Easy] :
[Colours]

just found that interesting. Not in the mood to check the source code to find out why, but there is no need for you to fix it.

Timing sections check is not implemented yet (see viewtopic.php?p=922062#p922062 if you forgot) (not on your list of todo, so just reminding you)

Another stupid bugs that I doubt will come up:
If the timing sections are like this:
56713,-100,4,1,1,75,0,1

83947,-100,4,1,1,75,0,0
then the it will be read as 
Kiai #1: Starts on 00:56:713, until the end

Feature Request:
Warn if 2 notes are at the same point in time (Forgot if this was mentioned before)
Check for unused custom hitsounds (including bogus names) (was this supposed to be already implemented in 0.7? because it doesn't seem to work for me.)
Warn about sbed hitsounds (I know some users dislike them, so I a notficiation about them would be nice)

All the new features I tried seemed to work, so great job with 0.7. I wish you the best of luck as you move onward (and a modding companion would be nice)

Edit: I thought about the comboburst thing, and I think the code should probably go something like this.(going to be typing in visual basic style since I have been using that a lot lately)
If it ends in ".png" then
If the first few characters are "comboburst-" then
read the characters after the "comburst-" until you find '.'
if characters inbetween those 2 points are not numbers then
trigger error
end if 'else ignore
end if
end if

so confusing without tabs, but I think you get the general idea
Zlew
423 posts
Joined June 2010
Zlew
AIBat doesn't work D:
ziin
2,632 posts
Joined January 2010
ziin
make sure it's not in a folder with a ! in it.
Zlew
423 posts
Joined June 2010
Zlew
But it's not the point.
It works with all folders, but not with folders with osu! beatmaps. Even if you are outside osu! songs folder.
ziin
2,632 posts
Joined January 2010
ziin
In these situations it's best to describe the problem fully.

You said AIBat doesn't work, now you're saying it works with all folders?

What happens when you open a folder?
Rei Hakurei
1,983 posts
Joined February 2011
Rei Hakurei
is it like this?
(wrong file lol, yeah because i tried it rushly, but it may applies to all JAR..)
if so, then evacuate move it from UNICODE based name folder... (CMIIW, win7 too?) to non UNICODE based folder, (like base drive "C:\" etc.)
Zlew
423 posts
Joined June 2010
Zlew

ziin wrote:

In these situations it's best to describe the problem fully.

You said AIBat doesn't work, now you're saying it works with all folders?

What happens when you open a folder?
When i open folder with map, nothing happens.

When i open any folder:
this happens
ziin
2,632 posts
Joined January 2010
ziin
try moving everything to the root of the drive.
Zlew
423 posts
Joined June 2010
Zlew
root?
ziin
2,632 posts
Joined January 2010
ziin
c:\ or d:\ or e:\
Zlew
423 posts
Joined June 2010
Zlew
still same
akrolsmir
606 posts
Joined November 2010
Topic Starter
akrolsmir
It's good that at least AIBat opens up, unlike for CnF... The message when you try to open up any non-beatmap folder is expected, and it sounds like an exception is thrown on all folders with .osu files in them, which would prevent the program from opening anything as you described.

Try unzipping this test folder and putting it on the root drive, and trying to open that with AIBat.
Zlew
423 posts
Joined June 2010
Zlew
Still nope
TicClick
Global Moderator
4,466 posts
Joined February 2011
TicClick
It runs only from root folder.
After start, it opens songs' folders but doesn't show any files inside of 'em. They are kind of.. empty, though I know it's wrong. Well, it shows subfolders only.

Windows 7 x86, Java v6 upd27. Tried AIBat v0.7b and 0.6.1b
ziin
2,632 posts
Joined January 2010
ziin
you're supposed to open a folder, not a file, so the folders will be empty. Just open the folder.
Sakura
osu! Alumni
7,979 posts
Joined March 2010
Sakura
You're supposed to find the path to where the .osu files are supposed to be (a.k.a the song folder) after that just hit the enter button (or press the enter key)
[Au]-[Revoir]
43 posts
Joined September 2011
[Au]-[Revoir]
AIBat is really awesome 8-)
TicClick
Global Moderator
4,466 posts
Joined February 2011
TicClick

Sakura Hana wrote:

You're supposed to find the path to where the .osu files are supposed to be (a.k.a the song folder) after that just hit the enter button (or press the enter key)

ziin wrote:

you're supposed to open a folder, not a file, so the folders will be empty. Just open the folder.
Hm. I tried it, but nothing happened. Now I try to open some songs' folders, and it works.
Some folders don't open:
akrolsmir
606 posts
Joined November 2010
Topic Starter
akrolsmir
Glad to find it's working, at least partway.

About those beatmaps that don't open, though- I can't seem to replicate the error for the first two.

Images


For the last one, though- that's a problem with the age of the beatmap. It's file format is v5, and contains formatting that breaks AIBat. I never implemented backwards compatibility since maps that old either are ranked or graveyarded, so you shouldn't need to use it for those anyways.
show more
Please sign in to reply.

New reply

0
12 / 327