Uhm. Holy... Fuck. I just don't even know how the heck you are doing all of this
Bug with the new live-time configuration:
fancy headlines o.O1) Unchecking the "custom colours" option resets custom colors, so enabling it again does nothing.
General bugs / stuff:
1) The key selection window doesn't have a cancel button, just an exit button. This could be bad if you mess up the keys
like me and want to restore them o:
2) Could it be that you completely broke the command line functionality? When trying to run the program with
"D:\system\osu!\KeysPerSecond-v5.0.exe D:\Documents\KeysPerSecond – Default.kpsconf2" the argument is just ignored and the config window opens as usual. The special character "–" shouldn't be a problem since version 4.5 had no trouble at all o:
3) Maybe change the color handling of the little check marks in the config menu. They could just have the same foreground and background colors as the text, that would make them a lot more readable with certain colors, especially when the background color is very dark. :>
4) Everything was fine. But I pressed Ctrl + Y and
this weird stuff happened.
Every time I press Ctrl + Y again, the script switches from two, to one window o.O Also, the first time I pressed it, the windows went grey again
I should probably mention, that I unchecked
every visible element in the config menu just before this happened! This alone caused the area for right clicking to disappear completely.
Bugs with the text based config file-format:
1) You should
DEFINITELY put caps on all of the values! There is no cap on size, precision, update rate, etc. Putting a value greater than the maximum value in the config window crashes the whole config menu when pressing the button that would load the out-of-bounds value from the config file.
2) Same goes for the graph backlog, this time it completely breaks the graph's functionality.
3) At first I thought, you had put a cap on this one... but you didn't c: The update rate
(and this is pretty funny) cannot be zero, however it
can be negative! :^) This breaks pretty much all of the calculations, not the key counter though
4) Opacity setting is not happy with negatives again, this time some more stuff happens: If the foreground color opacity is negative, the overlay is simply invisible and doesn't close right away; if the background opacity is negative, the overlay doesn't spawn at all.
In addition: The overlay doesn't spawn either, when the background opacity is greater than 1.0, and is (yet again) invisible when the foreground opacity is greater than 1.0.
Positive stuff: yay ヽ(。・ω・。)ノ
1) When two keys have the same index value, the script handles it! It seems to be just after the reading order, so the lines' order in the file.
2) I'm pretty sure Java doesn't do this by default, so I'm just gonna give props to you for this: Different variable types in the config files are handled! So, putting "1" at size (instead of "1.0") works just fine, also putting anything but "true" or "false" in a Boolean-expected field still works just as usual! c:
One more bad thing about this though: Putting strings into any number-expected field crashes the whole script when loading the config file.
All in all:
I repeat, SET MAXIMUM VALUES inside of the config files!
It would be better, if the script would actually no throw an error, but rather choose an acceptable value on its own! So if the user would do a size of 8.0, the script would change that to 2.0, since that's the highest value allowed in the config window.
Also fix the command line argument stuff o:
The rest is relatively unimportant ^~^
Anyway.
Contributing to this project is really fun, although I'm sort of busy doing stuff for school lately >.<