Mustaucheman wrote:

Amazing job here, is there any way to make the graph/cur update faster?

Agrrox wrote:

is there way to rearrange key order ?

edit: it seems to launch on mac, will test if it works with wine version of osu, overlay doesnt work for mac.

Previeuw

Agrrox wrote:

Also to the interface... i think it will be better to invert the color of background and key, so its always visible when pressed. nice program

NightNarumi wrote:

Woah, this seems really interesting, gonna try this out tomorrow :p

Agrrox wrote:

looks much better to me

can you implement ability to change colour? that would be cool to be able to change this.

Mizyx wrote:

I think it would be great if you added opacity , cause some users could play better with it on

iloveyou4ever wrote:

This is a very nice program
But can you add the function to show the 1 demical digits for the key per seconds?
I think it would be better
Thanks

Worst Mouse Aim wrote:

You can get that by external programs... I guess the reason is streaming?

Mizyx wrote:

Edit:
Also resizable will be great too

Mizyx wrote:

I think it would be great if you added opacity , cause some users could play better with it on

Mizyx wrote:

Edit:
Also resizable will be great too

Zard0Z wrote:

This looks good. :3

spukystar wrote:

nice

Agrrox wrote:

I'm getting input conflicts when using KeysPerSecond with beatoraja BMS player(Be-Music Script). Input is delayed or not registering my presses when using both programs at same time.

https://github.com/exch-bms2/beatoraja

• 
  1. (ironically) It doesn't launch when the path of the executable (or the jar) contains a "!"... which is bad... in a game, that's called "osu!"...
  I moved the file to "D:\system\osu!" and it didn't work, in "D:\system\" however, it did! So, that's a bug, i guess.
  
  2. The option "Overlay osu!" is (well irrelevant, who would not want it to overlay osu!? But also) not working when osu!'s in fullscreen.
  
  3. It drains the performance way too much for what it's doing. For me, at a refresh rate of 1000 ms, it has almost the same CPU load as osu! itself at an unlimited frame rate (usually around 700-1500 fps). Even on 125 ms I still experienced lag spikes in osu!. But at least there's a simple solution for that: Just don't ever fucking use Java for real-time processing. Use C#, C++, Python, even fucking AutoHotkey if you like, but not Java...
  
  4. I don't know what caused it and it doesn't happen anymore, but at first, while playing, the program was constantly lighting up in the taskbar as if it had a notification for me.

• 
  1. Making an installer, rather than a standalone file. It would be easier to manage the config file, since it could be loaded automatically.
  
  1.5 Also right now the Load Config and Save Config windows always default to the documents folder. With an installer you could have it remember where the last file was loaded from.
  
  2. Saving the position of the overlay in the config file. (And/Or making it easier to position, like by snapping to the edges of the screen)
  
  some minor things left:
  
  1. Maybe do the opacity in percent, would be easier for the users, I think.
  
  2. The adding of keys is weird. Dunno. It works perfectly fine, but it's weird >.< Maybe make a window pop up and have the user then press the key, not before pressing the button! o:
  
  3. The config files could just be ordinary .cfg-files. Right now, you can't even edit them by hand (what I really like to do).
  
  4. Make the overlay right-clickable (I'm kind of influenced by Rainmeter here, it does that really nicely). At least for maybe exiting, pausing the counter, etc. this function could be very useful.

SALZKARTOFFEEEL wrote:

Huh, I actually like this little program a lot, but it has some bugs and other weird stuff I want to point out!

Oh man, I hope I wasn't to nitpicky with you here :/
Again, I really like this program, at least the idea is fantastic, but these are the things I came across the first hour or so of testing.
I'm not expecting you to fix all of them, but at least read through these and consider it :^)

• 
  1. (ironically) It doesn't launch when the path of the executable (or the jar) contains a "!"... which is bad... in a game, that's called "osu!"...
  I moved the file to "D:\system\osu!" and it didn't work, in "D:\system\" however, it did! So, that's a bug, i guess.
  
  2. The option "Overlay osu!" is (well irrelevant, who would not want it to overlay osu!? But also) not working when osu!'s in fullscreen.
  
  3. It drains the performance way too much for what it's doing. For me, at a refresh rate of 1000 ms, it has almost the same CPU load as osu! itself at an unlimited frame rate (usually around 700-1500 fps). Even on 125 ms I still experienced lag spikes in osu!. But at least there's a simple solution for that: Just don't ever fucking use Java for real-time processing. Use C#, C++, Python, even fucking AutoHotkey if you like, but not Java...
  
  4. I don't know what caused it and it doesn't happen anymore, but at first, while playing, the program was constantly lighting up in the taskbar as if it had a notification for me.

And here are a few feature requests I have:

• 
  1. Making an installer, rather than a standalone file. It would be easier to manage the config file, since it could be loaded automatically.
  
  1.5 Also right now the Load Config and Save Config windows always default to the documents folder. With an installer you could have it remember where the last file was loaded from.
  
  2. Saving the position of the overlay in the config file. (And/Or making it easier to position, like by snapping to the edges of the screen)
  
  some minor things left:
  
  1. Maybe do the opacity in percent, would be easier for the users, I think.
  
  2. The adding of keys is weird. Dunno. It works perfectly fine, but it's weird >.< Maybe make a window pop up and have the user then press the key, not before pressing the button! o:
  
  3. The config files could just be ordinary .cfg-files. Right now, you can't even edit them by hand (what I really like to do).
  
  4. Make the overlay right-clickable (I'm kind of influenced by Rainmeter here, it does that really nicely). At least for maybe exiting, pausing the counter, etc. this function could be very useful.

Aaaaaand that's it!

Wow, what a long list D:

I know, some of these are not easy to fix, for example the performance thing, when you only know Java, or the "Overlay osu!" thing, because osu!'s a dick and it always wants to be on top of everything.
I hope, you at least understand what I mean with those things c:

Obviously, if you have questions, or you fixed something, let me know! I would love to see this program on my screen every day

I hope, I could help you with this feedback :3

1. This is really interesting, lol.

2. I'm aware of this 'bug'. But it's not something I can fix. Well I tried but that didn't really work out. Since when I set my program to 'always on top' mode it's always competing with osu! for being to top most window. So in the end neither program was working like it should

3. Real time processing is done in C actually. And on my old laptop (Intel Centrino CPU) it only takes 0~2% CPU (Firefox takes 10~50%). What really takes most of the CPU is the graph. But even so on my laptop that also only takes 2~4% CPU (slowest update rate 1000ms).

Thanks to your performance concerns I was able to find a major issue xD. Turns out that there was still some very old code left that was ultra inefficient, so please blame me for this and not Java >.<. Problem was that it would become exponentially more inefficient on a faster computer, so that's why I didn't really notice it. So I've changed it and on my computer the program now uses about 20 times less CPU xD.

4. It should only do that if the window was made visible again. So either on startup or when pressing Ctrl + Y. I'll see if I can replicate it though.

1. I personally really dislike installers. Since I like being able to drag my programs from computer to computer. As for the config part that is also possible without the program being installed, so I might look into that. But I'll make it optional for sure, since I for example have multiple config files for different mania modes and standard mode. Another option would be to associate the extension with the program so that you can just open the config files automatically. But that would require that you don't move the program to a different location. Hmm, this one is a little difficult xD

1.5 Also possible without an installer

2. I could make it snap to the edges of a screen but that would be troublesome for user that have multiple monitors. I think I'll just add a 'snap' option in the command menu I'm going to add for feature #4.

1. I didn't do it in percentages O.O shame on me..... >.<

2. Yup I totally agree the addition of keys is weird so weird that I always mess up myself..... Adding another option dialog would be possible. But I thought that the GUI was already pretty dialog heavy. If that's not an issue then I'll just make another dialog for it.

3. Hmm.... technically they could be. But currently they are serialized objects. Which is really really really convenient for me since I can load them really easy xD. Making them text based would be possible, but it would also be a lot of work, I'll see though if I'm in the mood I might do it

4a. I should be able to implement this quite easily as soon as I have some time.

4b. Todo: pause functionality xD since that currently doesn't exist.

SALZKARTOFFEEEL wrote:

Man, I'm so glad I could help you! c:

1. This is really interesting, lol.

Right? o: I could only imagine some kind of error, wehre the exclamation mark is treated as part of the actual code. I'm not sure, but in Java that would be a Boolean negation, right?

SALZKARTOFFEEEL wrote:

2. I'm aware of this 'bug'. But it's not something I can fix. Well I tried but that didn't really work out. Since when I set my program to 'always on top' mode it's always competing with osu! for being to top most window. So in the end neither program was working like it should

Okay, I actually wanted to run it with admin and with system privileges and I found another (veeery strange) bug! When running this program with system rights (using PsTools) I can't load/save config files
I think, you can just ignore this bug, because who runs this with system rights? But I find it pretty interesting nonetheless
And no, running it as admin doesn't help keeping the overlay on top, nor does running as system :c

SALZKARTOFFEEEL wrote:

3. Real time processing is done in C actually. And on my old laptop (Intel Centrino CPU) it only takes 0~2% CPU (Firefox takes 10~50%). What really takes most of the CPU is the graph. But even so on my laptop that also only takes 2~4% CPU (slowest update rate 1000ms).

Thanks to your performance concerns I was able to find a major issue xD. Turns out that there was still some very old code left that was ultra inefficient, so please blame me for this and not Java >.<. Problem was that it would become exponentially more inefficient on a faster computer, so that's why I didn't really notice it. So I've changed it and on my computer the program now uses about 20 times less CPU xD.

Now that seems pretty good! I'm looking at 0.8% CPU Power at 200 ms, instead of >20% at 1000 ms refresh rate!
Wow, actually i still don't like Java all that much But it's not that slow anymore, I guess c: *Sorry for blaming you Java ;-;*

SALZKARTOFFEEEL wrote:

4. It should only do that if the window was made visible again. So either on startup or when pressing Ctrl + Y. I'll see if I can replicate it though.

For the record, it started doing that again! I noticed, it is actually stealing the window focus while it's doing that!
It only occurs when the Overlay osu! option is set.

SALZKARTOFFEEEL wrote:

Features:

1. I personally really dislike installers. Since I like being able to drag my programs from computer to computer. As for the config part that is also possible without the program being installed, so I might look into that. But I'll make it optional for sure, since I for example have multiple config files for different mania modes and standard mode. Another option would be to associate the extension with the program so that you can just open the config files automatically. But that would require that you don't move the program to a different location. Hmm, this one is a little difficult xD

Yeah, I forgot to write that, I meant an optional installer alongside the standalone!
I don't think making the config files launchable would be a good idea, they're usually stored in a location you don't normally go to when you want to run something.

SALZKARTOFFEEEL wrote:

1.5 Also possible without an installer

Alright ^^

2. I could make it snap to the edges of a screen but that would be troublesome for user that have multiple monitors. I think I'll just add a 'snap' option in the command menu I'm going to add for feature #4.

Same here, alright ^^

1. I didn't do it in percentages O.O shame on me..... >.<

haha, yea. That was SUCH a big issue! Not doing that in percentages! Pftt.

SALZKARTOFFEEEL wrote:

2. Yup I totally agree the addition of keys is weird so weird that I always mess up myself..... Adding another option dialog would be possible. But I thought that the GUI was already pretty dialog heavy. If that's not an issue then I'll just make another dialog for it.

For me, that's totally not an issue at the moment. The program is not very dialog heavy in my opinion, since you only have one extra window open at the time (two if you count the main window). So I think, you'd be way better off with another dialog box c:
Also, the window with the key list wouldn't have to close every time you add another key!

SALZKARTOFFEEEL wrote:

3. Hmm.... technically they could be. But currently they are serialized objects. Which is really really really convenient for me since I can load them really easy xD. Making them text based would be possible, but it would also be a lot of work, I'll see though if I'm in the mood I might do it

Well, that's sort of just me that I want to edit them by hand, but if it is that much more convenient with serialized objects, leave it like that!

SALZKARTOFFEEEL wrote:

4a. I should be able to implement this quite easily as soon as I have some time.

4b. Todo: pause functionality xD since that currently doesn't exist.

Great c:

SALZKARTOFFEEEL wrote:

No hurries with these, you already changed so much so quick! I appreciate it very much :>

Again, I'm very happy that I could help you with this :3

Roan wrote:

If I can't fix the bug I'll just copy the program to the temp directory and execute it from there xD. Not all that convenient but it would work. From what I've been able to find out an ! in a file path is sometimes used to specify a zip archive so that's probably what's causing the issue. And you right on what the ! is in Java, it's indeed boolean negation ^^.

Roan wrote:

xD yet another interesting bug. I'm guessing that when running as system you can't open the file since it is owned by the user and not by system. Not sure though, but yeah I'm not going to fix it .

Roan wrote:

xD that's quite the improvement! And yeah Java has it's pros and cons, but the same goes for every other language, so for now I'm sticking with Java xD.

Roan wrote:

Actually now that you mention it, that is intended behavior xD. Well actually it's a side effect. When you have to overlay osu! option enabled the program will make every attempt to stay the top window. Part of this functionality is to immediatly jump on top of other windows when they try to jump on top of the window. And, well, apparently that causes the icon to flash :/. It's not really I can remove though since if it doesn't have this functionality it is not guaranteed that I'll stay on top. When it's flashing it's basically telling you that it won the competion for top window from another program . So I'm not sure if there is a way to disable it, but I'm going to look into it.

Roan wrote:

Well, true, I'll give it some more though and hopefully come up with a good system.

Roan wrote:

I just implemented this xD.

Roan wrote:

I won't say that it won't happen but it's at the bottom of my todo list .

Roan wrote:

And again thank you for helping ^^

SALZKARTOFFEEEL wrote:

Roan wrote:

If I can't fix the bug I'll just copy the program to the temp directory and execute it from there xD. Not all that convenient but it would work. From what I've been able to find out an ! in a file path is sometimes used to specify a zip archive so that's probably what's causing the issue. And you right on what the ! is in Java, it's indeed boolean negation ^^.

huh, I've never heard of an exclamation mark specifying an archive before. Well, I guess it's not that big of a problem if it works from the temp directory
Oh, yay (ノ･ω･)ノ I got it right! Boolean negation! c:

Roan wrote:

xD yet another interesting bug. I'm guessing that when running as system you can't open the file since it is owned by the user and not by system. Not sure though, but yeah I'm not going to fix it .

Actually, I think I've sort of messed up the explanation there xD What actually happens is that the explorer window doesn't even open at all!
But yeah, it's really not something to worry about c:

Roan wrote:

xD that's quite the improvement! And yeah Java has it's pros and cons, but the same goes for every other language, so for now I'm sticking with Java xD.

I still like Python better! ^~^

SALZKARTOFFEEEL wrote:

Roan wrote:

Actually now that you mention it, that is intended behavior xD. Well actually it's a side effect. When you have to overlay osu! option enabled the program will make every attempt to stay the top window. Part of this functionality is to immediatly jump on top of other windows when they try to jump on top of the window. And, well, apparently that causes the icon to flash :/. It's not really I can remove though since if it doesn't have this functionality it is not guaranteed that I'll stay on top. When it's flashing it's basically telling you that it won the competion for top window from another program . So I'm not sure if there is a way to disable it, but I'm going to look into it.

Well, I actually thought about that. Maybe there's another method in Java for this that doesn't make it flash :v
Isn't really a problem at all, but I personally have found it a bit distracting.

SALZKARTOFFEEEL wrote:

Features:

Roan wrote:

Well, true, I'll give it some more though and hopefully come up with a good system.

I'd like it if you would :3 Rechecking all these checkboxes / reloading the config file over and over again is kind of annoying. Right now I can totally forgive you for that, but when an installed program does that, man... It's like when you scroll down, click on something, go back and you're on top of the list again ._.
I only just read at your todo list that you're working on passing the config file via the command line, which is a fantastic idea! :3

SALZKARTOFFEEEL wrote:

Roan wrote:

I just implemented this xD.

ヽ(｡･ω･｡)ﾉ

Roan wrote:

I won't say that it won't happen but it's at the bottom of my todo list .

Alright :^)


One more thing:
This is probably supposed to happen, but the config window doesn't appear in the taskbar. If it is just an option you can simply set to true or something, in my opinion, you should But if it is because of maybe the type of window (like a special type for dialogs, overlays, etc.) and it is a lot of effort to edit, just leave it like it is c:
I just wanted to point it out anyway ^^

SALZKARTOFFEEEL wrote:

Roan wrote:

And again thank you for helping ^^

Thanks for being patient, I've totally forgotten to reply to you D:
And thanks for letting me help, I really enjoy it! <3

I never would've thought that putting it in the osu! folder would make it stop working .

Roan wrote:

Euh I guess I've fixed it ¯\_(ツ)_/¯

Roan wrote:

Implemented the passing of config files via the command line, since that was easy to implement anyway xD. Still thinking of more improvements here. Also I noticed that the overlay osu! option wasn't being saved to the config xD so I've fixed that too.

Roan wrote:

Yeah that isn't happening since they are indeed actually dialogs . And as far as I know there is no (easy) was to give dialogs an icon. If it's a real problem I could just give them frames but that introduces other problems .

Roan wrote:

And your help is much appreciated since you see the bugs I don't see because you try things I'd never think off xD.

Roan wrote:

I never would've thought that putting it in the osu! folder would make it stop working .

SALZKARTOFFEEEL wrote:

Roan wrote:

Euh I guess I've fixed it ¯\_(ツ)_/¯

So you did use a different technique then? c:

SALZKARTOFFEEEL wrote:

Roan wrote:

Implemented the passing of config files via the command line, since that was easy to implement anyway xD. Still thinking of more improvements here. Also I noticed that the overlay osu! option wasn't being saved to the config xD so I've fixed that too.

I'm guessing simply: <exe-path> "<config-file>" o:

SALZKARTOFFEEEL wrote:

Roan wrote:

Yeah that isn't happening since they are indeed actually dialogs . And as far as I know there is no (easy) was to give dialogs an icon. If it's a real problem I could just give them frames but that introduces other problems .

Yeah, got another one right! c: Well, as I said, it's not a real problem. The program is still in the Alt+Tab-Menu, which is probably more important! It's completely fine this way :3

SALZKARTOFFEEEL wrote:

Roan wrote:

And your help is much appreciated since you see the bugs I don't see because you try things I'd never think off xD.

That's sort of a skill I have, I do the weirdest stuff until everything breaks

SALZKARTOFFEEEL wrote:

Roan wrote:

I never would've thought that putting it in the osu! folder would make it stop working .

Me neither xD

Roan wrote:

I'm still using the same technique but I have removed all focus calls. As far as I can tell it still works though. They were kinda left over from when I was trying to render it on top of fullscreen osu! But since that doesn't work anyway I removed them, I hope I didn't break anything xD.

Roan wrote:

Yup the program takes a single argument which is the config file path (also don't use quotes around the path, spaces in the path are handled). If the config is in the same directory as the executable you only have to specify the filename . Oh and also don't accidentally forget the file extension

;-- setup stuff --;
#SingleInstance, force
#Persistent

Loop {

;-- logic --;
WinWaitActive, osu!
WinWait, ahk_class SunAwtFrame
WinWait, Keys per second
WinSet, AlwaysOnTop, OFF, osu!

}
Return    ;-- Return, just in case an error happens and the loop breaks

SALZKARTOFFEEEL wrote:

Roan wrote:

I'm still using the same technique but I have removed all focus calls. As far as I can tell it still works though. They were kinda left over from when I was trying to render it on top of fullscreen osu! But since that doesn't work anyway I removed them, I hope I didn't break anything xD.

Yeah, i was kind of wondering why you would even need to get the window focus, but I knew about this windows 'bug' that sometimes keeps the inactive window above the active one when the focus changes at some weird point in time, I thought you were trying to use that.

SALZKARTOFFEEEL wrote:

Roan wrote:

Yup the program takes a single argument which is the config file path (also don't use quotes around the path, spaces in the path are handled). If the config is in the same directory as the executable you only have to specify the filename . Oh and also don't accidentally forget the file extension

Huh, it handles spaces! I've never seen something like this in command line arguments c: Also great, that the config window doesn't appear in the first place.

SALZKARTOFFEEEL wrote:

Okay. After tinkering around with my good old friend AutoHotkey, I've sort of found a workaround for the "overlay osu!" Setting.
I have an AutoHotkey script that lets me have a window in AlwaysOnTop-Mode. I just found out that when I want to have your overlay on top of osu!, I can simply deactivate the AlwaysOnTop property of the osu! window! This keeps the focus on osu! but brings the overlay in front!
But there's a catch, be aware D:
Because osu!'s a dick, every time the focus changes (i.e. I press Alt+Tab), osu! pushes itself back on top of the other windows and the overlay.

Soo, if this helps you, I'm glad, if not, well... I'm gonna keep trying!
Right now the only thing I could probably do would be to (veery inelegantly) write another AHk script that steels the property from the osu! window every time it gets activated and the overlay is present. But that wouldn't be a real solution, would it? D:


EDIT:
This script I wrote fixes the issue. It is a bit wonky, but it works without any input delay or lag (at least for me) and I just wanted to share it c:
It is just 9 simple AHk lines, 3 of which are a Loop, 2 are some setup stuff and only 4 lines are the actual logic.
As I pretty much described earlier, it just tests for the osu! window to be in foreground, tests for the overlay to exist and then just steels the AlwaysOnTop property from the osu! window.

Source Code (not that there are any people who know AutoHotkey ^~^)

;-- setup stuff --;
#SingleInstance, force
#Persistent

Loop {

;-- logic --;
WinWaitActive, osu!
WinWait, ahk_class SunAwtFrame
WinWait, Keys per second
WinSet, AlwaysOnTop, OFF, osu!

}
Return    ;-- Return, just in case an error happens and the loop breaks

Yet another EDIT:
osu! seems to have problems with not running on the topmost layer, I am rarely getting stutters here and there, even though the overall performance is not effected o:
I think this is pretty much like disabling fullscreen mode, but with less (pretty much no) input lag. I don't know what I think about this.

Roan wrote:

Well I didnt actually need the focus. However the method to place a window on top of all other windows automatically makes a focus all :/ I was trying to call this method everytime the window was no longer the top most window. However what happened was that osu! and KeysPerSecond started a contest and kept overlaying each other xD or osu! minimized.

Roan wrote:

Yeah I though that was usefull so I made it parse spaces .

Roan wrote:

I-I-I'm filing a bug report , your script doesnt work for me . I did know about AutoHotkey though ^^.
However it did give me an idea. I suppose it would be possible to override the alwaysOnTop property using either C or C++. If thats the case then I can just include the functionality in my program since Java can make native calls . So I'm going to look into that.

Roan wrote:

Also did I mention you're awesome? If not: you're awesome!

SALZKARTOFFEEEL wrote:

Roan wrote:

Well I didnt actually need the focus. However the method to place a window on top of all other windows automatically makes a focus all :/ I was trying to call this method everytime the window was no longer the top most window. However what happened was that osu! and KeysPerSecond started a contest and kept overlaying each other xD or osu! minimized.

Great, an endless loop of windows fighting for attention!

Roan wrote:

Yeah I though that was usefull so I made it parse spaces .

It is pretty useful, actually! o: It's kind of weird, since I've never seen it, but I like it

Roan wrote:

I-I-I'm filing a bug report , your script doesnt work for me . I did know about AutoHotkey though ^^.
However it did give me an idea. I suppose it would be possible to override the alwaysOnTop property using either C or C++. If thats the case then I can just include the functionality in my program since Java can make native calls . So I'm going to look into that.

Yeah, file one if you want to But I don't think this is a real solution, as i said, unless you can implement it c:

SALZKARTOFFEEEL wrote:

Roan wrote:

Also did I mention you're awesome? If not: you're awesome!

Thank you so much I think you're awesome! (I mean, you knew about freaking AutoHotkey, that's a win already :3)
You put so much effort into fixing every single detail I complain about Thank you very much for that (っ◕‿◕)っ

Right click menu

So now let's hear all the new bugs I've introduced...

Roan wrote:

So this was an interessting one. I think I just created an osu! stroboscope, the result of trying to implement this was basically osu! and KeysPerSecond alternating being the top most window every 1/60th of a second xD. So I this might be impossible without changing setting for osu! . That being said there's probably some clever hack for this somewhere that I'm just not aware of. But untill I find it I guess I can't fix it

Roan wrote:

^^
I just really enjoy fixing complaints :3

Roan wrote:

Finally got around to implementing the right click menu

Right click menu

While at it I also implemented the functionality to pause the counter, accesible via the new menu or by using Ctrl + T .
And since everything was going well anyway I also implemented the snap to screen edge funtionality (works with multi-monitor setups).
Only 3 more points from you list to go xD, but they are mostly bug fixes.
So now let's hear all the new bugs I've introduced...

I figured, I want to put at least one non-ASCII-Smiley per forum post

SALZKARTOFFEEEL wrote:

Roan wrote:

So this was an interessting one. I think I just created an osu! stroboscope, the result of trying to implement this was basically osu! and KeysPerSecond alternating being the top most window every 1/60th of a second xD. So I this might be impossible without changing setting for osu! . That being said there's probably some clever hack for this somewhere that I'm just not aware of. But untill I find it I guess I can't fix it

huh, It seems as if the method you are using to set the window AlwaysOnTop also makes it the topmost window! That would cause such a 'stroboscope' effect as you call it :^)

SALZKARTOFFEEEL wrote:

Roan wrote:

^^
I just really enjoy fixing complaints :3

I totally understand that

SALZKARTOFFEEEL wrote:

Roan wrote:

Finally got around to implementing the right click menu

Right click menu

While at it I also implemented the functionality to pause the counter, accesible via the new menu or by using Ctrl + T .
And since everything was going well anyway I also implemented the snap to screen edge funtionality (works with multi-monitor setups).
Only 3 more points from you list to go xD, but they are mostly bug fixes.
So now let's hear all the new bugs I've introduced...

Not many bugs so far Just a few things that are (technically not bugs and) probably easy to fix/change!
First of all: This snap-functionality works sooo much better that I expected! I haven't even thought about putting that into the context menu c:
I thought you would implement it just like all other programs, making the window snap automatically. But this is so much better, since you don't have the trouble when you want to put the window say 3 pixels away from the screen border!

SALZKARTOFFEEEL wrote:

Okay, now onto the bad things

SALZKARTOFFEEEL wrote:

1) right clicking on the graph doesn't trigger the context menu. Yeah, that's it. The graph's potion of the overlay just doesn't count when right-clicked.

SALZKARTOFFEEEL wrote:

2) (this is a minor one) resetting the stats doesn't reset the graph o: It does reset the average line, but not the rest of the graph, maybe add that in c:

SALZKARTOFFEEEL wrote:

3) This one was probably there before, but the logic behind the counting seems to be pretty inconsistent o:
As seen below, the three overlays drift quite a bit from each other, in all the different values!
This is a live recording of me tapping X&Y (X&Z for normal people outside of Germany) but the counters seem to... disagree with each other
Right now I don't have enough time, but tomorrow (on Friday, that is) I could analyze the video just to see, what went wrong! o: I guess it's not a big deal, but I find it a bit odd that the counters drift like that.

Test

SALZKARTOFFEEEL wrote:

That's it for now!
Again, I don't have the time that I want to have right now, but maybe I'll find more errors and weird stuff in the future
(I think opening multiple counters could be a potential weak spot ;3)

SALZKARTOFFEEEL wrote:

ﾟ･✿ヾ╲(｡◕‿◕｡)╱✿･ﾟ I figured, I want to put at least one non-ASCII-Smiley per forum post

Roan wrote:

Glad you like it! For the next version I'm also going to add the option to move the overlay using the arrow keys, so you can position it pixel perfect xD. (Only active when the overlay has focus)

Roan wrote:

I actually knew about this one xD But I though I could just release it and quickly patch it some other time without you noticing, looks like I failed xD

Roan wrote:

o:

Roan wrote:

From your video it seems that the instances were not all started at the exact same millisecond time (the graph isnt shifting at the same time in all of them). And all the stats refer to the last second so if they are not started at the exact same time that could be the cause of the drift.

Roan wrote:

I'm actually more worried about that fact that not all your instances are reporting the same hit count for the keys O.O does that happen all the time? Since I can't replicate that no matter what I try.

Roan wrote:

The differences in max, avg & cur I can replicate when starting the instances at different times. It's also probably impossible for me to actually fix that since the only way to reliably fix that is shorten the time interval to 1 millisecond (which would be imprecise anyway due to the way windows timers work) also that places a massive load on the CPU

Roan wrote:

Plenty of work for me to do :3

Roan wrote:

I'm not good with non-ASCII-smiley's >.< but here we go ʘ‿ʘ

Roan wrote:

Also added you as a friend :3

SALZKARTOFFEEEL wrote:

Roan wrote:

Glad you like it! For the next version I'm also going to add the option to move the overlay using the arrow keys, so you can position it pixel perfect xD. (Only active when the overlay has focus)

Okay, I find myself simply never using such tings, since I'm usually more comfortable with using my mouse for it. But it can be nice to have! And it's not half as frustrating as using the mouse sometimes c:

SALZKARTOFFEEEL wrote:

Roan wrote:

I actually knew about this one xD But I though I could just release it and quickly patch it some other time without you noticing, looks like I failed xD

Sneaky, sneaky, sneaky... xD

SALZKARTOFFEEEL wrote:

o:?

SALZKARTOFFEEEL wrote:

Roan wrote:

From your video it seems that the instances were not all started at the exact same millisecond time (the graph isnt shifting at the same time in all of them). And all the stats refer to the last second so if they are not started at the exact same time that could be the cause of the drift.

Yeah, they weren't. I thought about that while trying to sleep and I wanted to try it out today. Looks like you were faster here c:

SALZKARTOFFEEEL wrote:

Roan wrote:

I'm actually more worried about that fact that not all your instances are reporting the same hit count for the keys O.O does that happen all the time? Since I can't replicate that no matter what I try.

uhm... (that's where the madness starts)... Me neither ._.
I have no idea what I did the first time, but I can't reproduce either, so it was.. uhm... something really weird... ¯\_(ツ)_/¯ Let's just ignore this unless it occurs again o:
(I'm trying my best not to blame that on Java for once )

since key press handling is done in C

SALZKARTOFFEEEL wrote:

Roan wrote:

The differences in max, avg & cur I can replicate when starting the instances at different times. It's also probably impossible for me to actually fix that since the only way to reliably fix that is shorten the time interval to 1 millisecond (which would be imprecise anyway due to the way windows timers work) also that places a massive load on the CPU

Yeah, well. It's not the biggest issue I guess, because what crazy person totally not me.. would want multiple counters at once? xD

SALZKARTOFFEEEL wrote:

Roan wrote:

Plenty of work for me to do :3

Well, I heard, you liked fixing complaints? So guess what? I've got even some more work for you (✿◠‿◠)

SALZKARTOFFEEEL wrote:

I hope, this is a simple one and just a little bug in the code:
(Just for the record, I can actually reproduce this one – I'm using this config file!)
Whenever Custom Colors are on, the background color opacity is set to 100% and the text color opacity is NOT set to 100%, this happens:

The top part just goes gray-ish for some reason. Again, this happens every time and I believe it's just some simple error – like switching up "<" and "<=" or something like that.

SALZKARTOFFEEEL wrote:

Roan wrote:

I'm not good with non-ASCII-smiley's >.< but here we go ʘ‿ʘ

haha, well.. I've written myself a little AutoHotkey script that let's me just write those out! ^~^
It also lets me use stuff like ≠, ≈, ≥, ≤, ©, etc. very easily. I don't know if I should improve on it a bit and make it public o:

SALZKARTOFFEEEL wrote:

Roan wrote:

Also added you as a friend :3

yay! ヽ(｡･ω･｡)ﾉ

(unlimited instances not included in the new release , unless your windows username contains an ! in that case you have problem)

Roan wrote:

Implemented the option to position to overlay using the arrow keys and improved moving the window using the mouse (it now actually stays at your cursor ).

Roan wrote:

This is now not so sneakily fixed

Roan wrote:

o: fixed

Roan wrote:

xD good job not blaming Java since key press handling is done in C
And well programs are weird sometimes ¯\_(ツ)_/¯

Roan wrote:

Well I could always add an 1 ms update rate to the drop down box, your computer probably won't like it though :3

Roan wrote:

I'm also totally not a crazy person, because I actually tried a GUI size of x100 and x0.1 :3

Roan wrote:

o: I'm impressed you actually found that one! Consider yourself lucky it's a rare bug I've already partially fixed it 4 times! The only case that I knew of that still caused this was adding only a single panel. So I guess you've found another way to do it xD. Going to try eliminate this bug for good this time 🐛 (it's cute though >.<).

Roan wrote:

I have no idea if there would be an audience for that, but you won't know if you don't try

Roan wrote:

And finally, I also fixed the bug where the program doesn't work when it's placed in a folder that contains a !.

Roan wrote:

Well I say I've fixed it, I actually just copy the program to the Windows temp folder :3

Roan wrote:

I also made a silly mistake making this that caused unlimited instances of the program to launch, Windows even said it was going to forcefully close programs because not enough RAM was available

Roan wrote:

(unlimited instances not included in the new release , unless your windows username contains an ! in that case you have problem)

SALZKARTOFFEEEL wrote:

Roan wrote:

Implemented the option to position to overlay using the arrow keys and improved moving the window using the mouse (it now actually stays at your cursor ).

yay c:

Roan wrote:

This is now not so sneakily fixed

Yup ^w^

Roan wrote:

o: fixed

o: great :3

SALZKARTOFFEEEL wrote:

Roan wrote:

xD good job not blaming Java since key press handling is done in C
And well programs are weird sometimes ¯\_(ツ)_/¯

They are.. ಠ_ಠ

SALZKARTOFFEEEL wrote:

Roan wrote:

Well I could always add an 1 ms update rate to the drop down box, your computer probably won't like it though :3

huh, well.. osu! runs at a refresh rate of about 0.7 ms while in game for me, so I don't think my computer would even have that big of an issue o:

SALZKARTOFFEEEL wrote:

Roan wrote:

I'm also totally not a crazy person, because I actually tried a GUI size of x100 and x0.1 :3

Why not, right?

SALZKARTOFFEEEL wrote:

Roan wrote:

o: I'm impressed you actually found that one! Consider yourself lucky it's a rare bug I've already partially fixed it 4 times! The only case that I knew of that still caused this was adding only a single panel. So I guess you've found another way to do it xD. Going to try eliminate this bug for good this time 🐛 (it's cute though >.<).

Uhm. With "Going to eliminate this bug for good" you meant that it's not fixed yet, right? Because it isn't xD

SALZKARTOFFEEEL wrote:

Roan wrote:

I have no idea if there would be an audience for that, but you won't know if you don't try

True, true o: I guess, if I'll make it customizable I could get a bigger audience. I'll see

SALZKARTOFFEEEL wrote:

Roan wrote:

And finally, I also fixed the bug where the program doesn't work when it's placed in a folder that contains a !.

man, you're stealing my job! D:

SALZKARTOFFEEEL wrote:

Roan wrote:

Well I say I've fixed it, I actually just copy the program to the Windows temp folder :3

If it works now, (and it does!) I guess it is a fix then c:

SALZKARTOFFEEEL wrote:

Roan wrote:

I also made a silly mistake making this that caused unlimited instances of the program to launch, Windows even said it was going to forcefully close programs because not enough RAM was available

:D

Roan wrote:

(unlimited instances not included in the new release , unless your windows username contains an ! in that case you have problem)

This sentence made me laugh soo hard!
But in this case you could (if you just really wanted to keep your username) change the temp directory's path

SALZKARTOFFEEEL wrote:

It's still a very weird bug, right? I've actually investigated a bit further on this and I've come up with this:
The program doesn't launch, when one of the folders/files* that make up the path of the executable end with an exclamation mark!
*files: There can only be one file in the path, the executable.
That means: If your username would be xXosu!pro2k17Xx, you wouldn't even have a problem, since the "!" is in the middle! Or if the executable is named osu!KeysPerSecond.exe and is in a folder called osu!stuff, it even still works with all the older versions.

I thing that's extremely interesting, because either each of the folders in a path is somewhat treated individually, or the combination of an exclamation mark and a slash ("!\") does something strange o:

Roan wrote:

Guess I'll at least add the option then since that takes no effort anyway :3. There's one thing to note though the osu! graphics are actually graphics, the overlay is just a normal program window so it isn't quite as optimized for quick rendering updates. I'm also not so sure how well the windows timers would handle it since they are imprecise. Also 10 ms is also quite fast

- I implemented a 1 ms and 5 ms update rate for you to play with :3 it does kill your CPU though, my CPU usage has increased by 400%-500% times. Also this in combination with big graph backlog can really kill your CPU . Also you need a very fast computer to properly run this since all the update calculation have to be done in 1 millisecond otherwise the calculations aren't 100% accurate anymore. Well have fun I guess

Roan wrote:

Quite right this isn't fixed yet. I read your post after I had already finished the new release. Also because this is quite a difficult bug to track down I have no idea when I will have fixed it completely

Roan wrote:

Better find some more bugs then

Roan wrote:

true however I don't think I'd ever run a program again if it instantly filled up my RAM xD. Is the ! sign even allowed in a windows username? (just checked it is maybe I should atleast throw an error at the user then in order to prevent RAM overload xD)

- I also implemented a fix for the infinite instances problem just in case someone's username ends with a !

Roan wrote:

I think I'm officially labeling this as the weirdest bug I've ever encountered xD.

This is my weirdest (and deadliest) bug yet

I've seen an antivirus labeling itself as malware, moving important DLLs of itself into quarantine, then completely malfunctioning and finally also moving parts of the windows operating system into quarantine. This bug was pretty bad, since it occurred on every machine that got the update! It was very tricky to fix and if you restarted your computer, you'd just get a blue screen of death on startup immediately, forever

Roan wrote:

Even worse, this probably affects other programs I wrote too hmm...

Roan wrote:

- Filter the config selection dialog to only show config files. This makes finding the files a lot easier xD.

Roan wrote:

- And I also fixed the rendering problem you were having, well it's really persistent so I'm not 100% sure but atleast your config file works now.

Roan wrote:

And that's it for now going to work on editable config files next :3 (no eta though )

SALZKARTOFFEEEL wrote:

Roan wrote:

Guess I'll at least add the option then since that takes no effort anyway :3. There's one thing to note though the osu! graphics are actually graphics, the overlay is just a normal program window so it isn't quite as optimized for quick rendering updates. I'm also not so sure how well the windows timers would handle it since they are imprecise. Also 10 ms is also quite fast

- I implemented a 1 ms and 5 ms update rate for you to play with :3 it does kill your CPU though, my CPU usage has increased by 400%-500% times. Also this in combination with big graph backlog can really kill your CPU . Also you need a very fast computer to properly run this since all the update calculation have to be done in 1 millisecond otherwise the calculations aren't 100% accurate anymore. Well have fun I guess

Well, my computer isn't immensely happy with 1 ms delay :3 For me the program takes about 30% CPU Load (17-20% on 10 ms), which would be okay, if osu! wouldn't be running :^)
But anyway, it's still nice to have fun to play with ^~^

SALZKARTOFFEEEL wrote:

Roan wrote:

Quite right this isn't fixed yet. I read your post after I had already finished the new release. Also because this is quite a difficult bug to track down I have no idea when I will have fixed it completely

Okay c:

Roan wrote:

Better find some more bugs then

SALZKARTOFFEEEL wrote:

Roan wrote:

true however I don't think I'd ever run a program again if it instantly filled up my RAM xD. Is the ! sign even allowed in a windows username? (just checked it is maybe I should atleast throw an error at the user then in order to prevent RAM overload xD)

- I also implemented a fix for the infinite instances problem just in case someone's username ends with a !

Yaay ヽ(｡･ω･｡)ﾉ
Do you just throw an error message immediately, or did you actually fix it? o:

SALZKARTOFFEEEL wrote:

Roan wrote:

I think I'm officially labeling this as the weirdest bug I've ever encountered xD.

nah, definitely not the weirdest bug I've ever seen

This is my weirdest (and deadliest) bug yet

I've seen an antivirus labeling itself as malware, moving important DLLs of itself into quarantine, then completely malfunctioning and finally also moving parts of the windows operating system into quarantine. This bug was pretty bad, since it occurred on every machine that got the update! It was very tricky to fix and if you restarted your computer, you'd just get a blue screen of death on startup immediately, forever

SALZKARTOFFEEEL wrote:

Roan wrote:

Even worse, this probably affects other programs I wrote too hmm...

haha, better fix them

SALZKARTOFFEEEL wrote:

Roan wrote:

- Filter the config selection dialog to only show config files. This makes finding the files a lot easier xD.

It does! ^^

Roan wrote:

- And I also fixed the rendering problem you were having, well it's really persistent so I'm not 100% sure but atleast your config file works now.

Great! c:

Roan wrote:

And that's it for now going to work on editable config files next :3 (no eta though )

Those would be great, yeah (ノ･ω･)ノ

SALZKARTOFFEEEL wrote:

So, here are a few more feature requests and bugs and other stuff:
1) Bug: Pressing any arrow keys won't move the window by one pixel, it will move it by two instead

Main.frame.setLocation(location.x - 1, location.y);

SALZKARTOFFEEEL wrote:

2) Notice: I just stress tested your program, I have to say, it is better than I thought it would be! When idle it takes about 2% CPU Load, while under maximum stress I could simulate (around 700 keystrokes per second) it takes around 35-40% CPU Load! So when idle, it really doesn't do anything besides refreshing it's display, but when it has to, it goes very high on the CPU and still doesn't struggle c:

SALZKARTOFFEEEL wrote:

2.5) Another extra notice: I played around with it some more Okay, soo: (this is just for fun) When I resized the window to double it's normal size, I found out that it actually still worked! Even the graph was properly aligned! It was veeery slow when I put it in full-screen, but even then it still worked!

Yeah I like to torture programs too

SALZKARTOFFEEEL wrote:

3) Feature request: Add an option to the context menu that allows the user to change the options again! So simply the option "Configure" that closes the overlay and reopens the config window! This could be combined with 3.5) very nicely.

3.5) Make the overlay live-configurable. So when clicking on the Configure button, the overlay doesn't close, but the config window still opens!
This config window would have to be slightly different, there qould have to be an Apply button, that doesn't close the window, but I don't think it would be that hard to do! Correct me if I'm wrong, of course c: