blissfulyoshi wrote:

Another feature:
Check for consistent BPMs for uninherited timing sections (assuming the decimal numbers don't break things here...)

Ayeen wrote:

Edit: thinking about what Bliss said, maybe you can add in some unherited timing that was used for metronome reset too.

blissfulyoshi wrote:

Small bugs:
pippidon and sliderb stuff come out as unused image files right now even though they are used (I am guessing this is not implemented yet, but I didn't see it on the changelog)

Ayeen wrote:

Sorry for the 3rd post, I suggesting to pin out the slider speed underneath the inherited time as well

Ayeen wrote:

About the storyboard, it seem there an issue where it cant elaborate subfolder content. And some skin element that was used to be reported as "unused" as well. Though, i wont say that would be a big issue

Example:
This was used, but reported unused skin element

SPOILER

fail-background.png
pause-overlay.png
star2.png

Example:
It reported missing, but actually it was used in SB

SPOILER

***Missing SB Files***
SB\fly.png
SB\beatmap.png
SB\star.png
SB\mduh.png
SB\storyboard.png
SB\black.png
SB\BG.png
SB\fly2.png
SB\and.png

Bleh ninjaed by Bliss

Ayeen wrote:

Slider speed I mean there was inherited timing like 0.75, 0.5,0.6 and so on. This is for map that are using more than 3 setup specifically. Though, I think this one can be easily notice via playing the map itself.

Ayeen wrote:

Well for the SB files missing:

Pit a pat Summer Where the SB folder is inside the song folder just like common SB files always. I think it be more complicated when there is another folder inside the "SB" folder like lyrics folder.

blissfulyoshi wrote:

Oh sorry for being vague, I was not talking about metronome switches (in fact those are fine). I was talking about consistent BPMs across diffs because sometimes a mapper forgets to change the BPM on all diffs when changing timing sections (very rare, but oh well)

About how to call me, yoshi is fine. The reason a lot of ppl use bliss is because there are multiple yoshis, but feel free to use whatever you want.

blissfulyoshi wrote:

Oh yeah, this was a strange scenario. If you add a word under [Colours], (during the mod he had [Colours] printed twice), AIBat says the combo colors are inconsistent even though all of them were exactly the same. (It took me a while to realize what the issue was, but I severely doubt that this will happen very often)

ziin wrote:

Update java, make sure you don't put aibat in the actual osu folder (I couldn't run it in any folder which had a ! in the path).

Card N'FoRcE wrote:

I swear that i can't get AIBat to work °°

I got the jar application, i run it and choose the beatmap folder.
After that i don't get anything else., whatever folder i choose it doesn't work.

I'm using Windows 7. If this helps, I have osu! sotred in a external drive, but i don't think it should be an issue °°

akrolsmir wrote:

I'm using Windows 7 too (64 bit). Hm... to try and control for other variables, try unzipping this test folder and putting it on your desktop, and trying to open that with AIBat. If that works then it probably has something to do with the external drive, if not then probably admin privileges. Additionally, what happens after you press the "Enter" button? Does the program freeze up (i.e. you can't click on anything/select any other folders) or just not respond?

Also, on the off chance this works, try opening folders with the direct open function (ctrl+O, or File>Open). Shouldn't make a difference but might as well give it a shot.

blissfulyoshi wrote:

Another suggestion: Give a warning if the preview time + the time difference between the start of the song and the first note is less than 1s. This is to make sure the preview time is long enough.

blissfulyoshi wrote:

Bugs:
Pippidon is not checked
selection-mod-xxxxxx should not be in a map skin (they don't show up) (there are actually quite a few skin files don't affect maps that are currently allowed right now, let me see if I can find a comprehensive list)

Taiko code printout for reference:

Card N'FoRcE wrote:

I already tried everything you said here: i tried opening the folder by both CTRL-O and manual folder selection, but when i press Enter it just does nothing °°
The program doesn't freeze up when i press Enter, it just doesn't analyze the folder whatever the path is (even C:\AAAA).
I tried having a look at admin rights, but i basically have everything allowed already and UAC is disabled. I also removed some kind of "lock" under Properties because this is a downloaded file.

I dunno what else to do xD

No, this won't automatically rank your beatmaps

akrolsmir wrote:

I spent ten minutes trying to understand this part... did you mean AudioLeadIn? If so, that's a good suggestion, but is 1 sec long enough?

akrolsmir wrote:

I left in selection-mod-xxxx and other similar files so that AIBat could be used to check skins as well beatmaps, but I guess that could cause problems with the overlap (i.e. someone accidentally includes a selection-mod-taiko in their beatmap folder and AIBat doesn't catch it). Perhaps I'll just create a short skin checker later and release it seperately.

akrolsmir wrote:

And the method for calculating bitrate seems great, the only thing stopping me is finding the length of an mp3 file (still).

akrolsmir wrote:

blissfulyoshi wrote:

Another suggestion: Give a warning if the preview time + the time difference between the start of the song and the first note is less than 1s. This is to make sure the preview time is long enough.

I spent ten minutes trying to understand this part... did you mean AudioLeadIn? If so, that's a good suggestion, but is 1 sec long enough?
Yeah...Audio lead-in. Not sure about the time 1-1.5 seconds is probably enough though.

blissfulyoshi wrote:

Bugs:
Pippidon is not checked
selection-mod-xxxxxx should not be in a map skin (they don't show up) (there are actually quite a few skin files don't affect maps that are currently allowed right now, let me see if I can find a comprehensive list)

Taiko code printout for reference:

Is Pippidon limited to exactly those frames, or can the animation be changed at will? (If it's the latter I'll have to implement that after I understand and properly account for SB animations. Which I should do anyways.) Sorry not sure about the details about the frames. I guess for now, just allow all frames.

- Checks for snapping in inherited points

blissfulyoshi wrote:

selection-mod-xxxxxx should not be in a map skin (they don't show up) (there are actually quite a few skin files don't affect maps that are currently allowed right now, let me see if I can find a comprehensive list)

Lybydose wrote:

- Checks for snapping in inherited points

Why does this matter? The only green sections that need to be snapped are those that start kiai and those that end kiai, and even end kiai is questionable.

ziin wrote:

Add in a "skin mode". Or add the skin specific stuff (like fruit-plate, selection mods, and circle highlight) in a "skin" tab, and apply its own custom skinset (like how hitcircle, hitcircleoverlay, and approach circle have to be together). If someone has a skin specific file in the beatmap, treat it like a skin, and put a notice at the top saying "if this is not a skin, you have an unnecessary skin file in your map and should remove it".

ziin wrote:

You can try reading the id3 tag, but the best way is to figure out the song duration.
And: http://stackoverflow.com/questions/3046 ... me-in-java

ziin wrote:

Also, I'm not sure which skin elements you check, but these are the important ones:
approachcircle
hitcircle
hitcircleoverlay
cursor
hit0 etc...

Questionable:
fruits

One thing you can do is check each and make a note that "X" is (much) bigger than the template skin dimensions.

Sakura Hana wrote:

Audio Lead-in wise i think 1.5 - 2 seconds before the approach circle appears is fine enough, however that would need a human modder probably (unless you can calculate time with approach rate), so i'd say 2 seconds until the first note should be enough, any less and throw a warning

blissfulyoshi wrote:

I forgot if this was reported already, but it seems that .png files inside a folder aren't reported correctly.

blissfulyoshi wrote:

Also, if some but not all of the kiai timings match up exactly in every diff, could you not post them. (so if only one kiai section is inconsistent among all the diffs, could you only post that one section?)

blissfulyoshi wrote:

Bug: AIBat suggest there should be an epilepsy warning even if epilepsy warning is on.

Lybydose wrote:

Why does this matter? The only green sections that need to be snapped are those that start kiai and those that end kiai, and even end kiai is questionable.

akrolsmir wrote:

Alright, from there I found a magical library that gets the bitrate directly for me; I might not even need song duration anymore! Also, does anyone have an mp3 file with a Variable Bit Rate and a known average to provide me for testing the bitrate that the library give me? Yay, let's use my map. http://osu.ppy.sh/s/32318 Bitrate is in the metadata (164kbps). More exactly, It is probably somewhere between 164-165.

blissfulyoshi wrote:

Bug: AIBat suggest there should be an epilepsy warning even if epilepsy warning is on.

I couldn't reproduce this, could you tell me which folder you were using when this happened?
As for this, I was checking http://osu.ppy.sh/s/26860, and if you look in the file, the epilepsy warning is on, but it warned me anyway. (Reminder: you can only see the visual effect of the epilepsy warning when playing standard, not through the editor)

Maav wrote:

File length is filesize divided by bitrate.
Hope that helps.

Edit:
True for both ogg and mp3.

blissfulyoshi wrote:

Yay, let's use my map. http://osu.ppy.sh/s/32318 Bitrate is in the metadata (164kbps). More exactly, It is probably somewhere between 164-165.

blissfulyoshi wrote:

As for this, I was checking http://osu.ppy.sh/s/26860, and if you look in the file, the epilepsy warning is on, but it warned me anyway. (Reminder: you can only see the visual effect of the epilepsy warning when playing standard, not through the editor)

akrolsmir wrote:

Anyone know if peppy is planning on updating AIMod to reflect these new guidelines? If so, I might drop AIBat or rework it to include less overlap. It's not that I mind working on it, I just don't want to waste my effort on duplicating functionality.

Equivalent wrote:

Minor bug:
Hitcircle.png not reported missing even if none in beatmap as the other elements of hitcirles are there.

blissfulyoshi wrote:

About the new guidelines, it seems there needs to be a fair amount of discussion before those are finished and in addition AIMod is fairly low on the priority list, so I wouldn't worry too much AIMod having duplicate functionality.

Pereira006 wrote:

Hello

I have question here

I just feeling problem aibat or i wrong

Aibat is working my pc ok but sometime i click folder will not show nothing
I just test aibat and i click folder from my map but still not show and i remove diff insane, normal now Aibat is working and show all. So i put again normal and insane and remove hard now aibat is not working again

I just test another folder map is same problem

I can't understand very well what problem Aibat...
Sometime Aibat is not working somehere diff...
or I wrong?

i use Windows XP SP3

and sorry my bad english

Sakura Hana wrote:

Probably you should include a link to the beatmap/osz in question so he can work it out and see what's the problem so he can fix it

lolcubes wrote:

From what I remember in earlier testing, you can't check mapsets which have empty maps. So for example, if you have a normal diff which is completely empty without a note, you won't be able to open the mapset at all. I haven't tested the latest version yet though.

blissfulyoshi wrote:

Feature Request xD:
Check to make sure there are no timing sections at the same point in time, unless the timing section is there to change the slider speed. (If you are lazy, you can just check to see if there are timing sections with the same offset xD)

Equivalent wrote:

blissfulyoshi wrote:

Feature Request xD:
Check to make sure there are no timing sections at the same point in time, unless the timing section is there to change the slider speed. (If you are lazy, you can just check to see if there are timing sections with the same offset xD)

Im pretty much guessing Bliss mean inherited time and unherited time on the same spot. It is rarely oocurs, if it only 1 offset maybe it easier to check without this app, but what if it got like 20 redlines? A good features I say

package javaapplication4;
import java.io.BufferedReader;
import java.io.InputStreamReader;
import java.net.URL;


/**
 *
 * @author Alex
 */
public class WebRetrieve {
    public static void main(String[] args) {
        try {
            URL url = new URL("http://osu.ppy.sh/p/beatmaplist");
            BufferedReader br = new BufferedReader(new InputStreamReader(url.openConnection().getInputStream()));
            String thisline = "";
            while((thisline = br.readLine()) != null) {
                System.out.println(thisline);
            }
br.close();
        } catch (Exception ex) {
            System.err.println(ex);
        }
    }

}

blissfulyoshi wrote:

Equivalent wrote:

Im pretty much guessing Bliss mean inherited time and unherited time on the same spot. It is rarely oocurs, if it only 1 offset maybe it easier to check without this app, but what if it got like 20 redlines? A good features I say

Well sometimes ppl put 2 uninherited sections at the same time (usually by accident....), so I want to avoid that from happening. Besides, of couse I want to prevent silly things like 2 inherited sections at the same time too.

Zhanger wrote:

just wondering-- could you release the source for beatmap url formatter and the osudistancechecker as well? Just curious P:

also --
This would allow you to read the page source for your beatmap url formatter therefore speeding up the process :3

ziin wrote:

a few suggestions:

I'm starting to include an AIBat post in my mods. If possible could you do this stuff:

*Stuff*

And as for coding this in java, I don't think there's a problem I rather like having separate programs from osu since you can't have 2 osu windows open.

Sakura Hana wrote:

This is becoming a quite helpful tool, it helps me save a lot of time, keep it up!

[Storyboard]
Unused Image Files:
comboburst-1.png
comboburst-5.png
comboburst-3.png
comboburst-0.png
comboburst-2.png
comboburst-4.png

package javaapplication4;

import javax.script.*;
import java.io.*;

/**
 *
 * @author Alex
 */
public class scripttest {

    static ScriptEngineManager mgr = new ScriptEngineManager();
    public static void main(String[] args) {
        try {
            scriptexec();
        } catch (ScriptException ex) {
            ex.printStackTrace();
        }
    }
        static void scriptexec() throws ScriptException {
        ScriptEngine se = mgr.getEngineByName("javascript");
        se.eval("println('hello world');");
    }
}

Sakura Hana wrote:

Also some spelling correction "A sideboard has been detected" -> "A Storyboard has been detected"

Lucy-Kaede wrote:

Nice app!
One minor thing I noticed though, when checking my combo colours against a guest difficulty it listed them like this:

SPOILER

(AIBat) - (Osu! Editor)
Combo 1 - Combo 2
Combo 2 - Combo 3
Combo 3 - Combo 4
Combo 4 - Combo 1

ziin wrote:

Since you managed to get hitsounds out of a map easily, would it be that difficult to put them back in? As in copy hitsounds in [insane] to [hard].

akrolsmir wrote:

Is this something worth attempting? Would people use it?

[Colours][Colours]

 - [Easy] :
olours]

[Colours]
[Colours]

 - [Easy] :
[Colours]

56713,-100,4,1,1,75,0,1

83947,-100,4,1,1,75,0,0

Kiai #1: Starts on 00:56:713, until the end

ziin wrote:

In these situations it's best to describe the problem fully.

You said AIBat doesn't work, now you're saying it works with all folders?

What happens when you open a folder?

this happens

Sakura Hana wrote:

You're supposed to find the path to where the .osu files are supposed to be (a.k.a the song folder) after that just hit the enter button (or press the enter key)

ziin wrote:

you're supposed to open a folder, not a file, so the folders will be empty. Just open the folder.

• 
  http://osu.ppy.sh/s/10580
  http://osu.ppy.sh/s/32003
  http://osu.ppy.sh/b/20450

blissfulyoshi wrote:

When popping http://osu.ppy.sh/s/31343 into AIBat, I got a whole bunch of snapping errors as the output, but I didn't actually find snapping errors in the map. Will try to out reason later when I am not as sleepy.

blissfulyoshi wrote:

Thanks ziin, changing the offset worked, now I just need to know what caused it (I think I can guess though)

Breeze wrote:

May I have a tiny request, that is add a 0% volume timing section check function

Sakura Hana wrote:

Also forgot if i already asked for this but, it would be nice if you added a check for spinners and post-spinner notes to check and warn if they dont have a new combo marker

akrolsmir wrote:

Thanks, Breeze! That was an oversight on my part, it's been fixed for the next release.