Woah, woah, woah! This is just a C++ equivelant to osu! API, not its own thing. To do what you have mentioned would require reading the replay file and not this. I suggest you go here to see what this API can and cannot do. Apart from that, I will definitely consider making an API to read replay files in the near future.DeathAlchemy wrote:
Heat maps from plays
How close you are to hitting the middles of the hit circles over the time of the map with a graph
How close you are to hitting the circles on time over the time of the map with a graph
Tips for players to help them with speeding up their playing, streams, and jumps
Recording stats while playing with ranks and such
Sorry i got really excitedabraker wrote:
Woah, woah, woah! This is just a C++ equivelant to osu! API, not its own thing. To do what you have mentioned would require reading the replay file and not this. I suggest you go hereto see what this API can and cannot do. Apart from that, I will definitely consider making an API to read replay files in the near future.DeathAlchemy wrote:
Heat maps from plays
How close you are to hitting the middles of the hit circles over the time of the map with a graph
How close you are to hitting the circles on time over the time of the map with a graph
Tips for players to help them with speeding up their playing, streams, and jumps
I don't think you really understand what this is for.DeathAlchemy wrote:
Sorry i got really excited
also while trying to build the application this happened...http://imgur.com/sbEvLxU
You are correct as i said before i didn't read the post all the way through, as i got excited and wrote what i did.Bauxe wrote:
I don't think you really understand what this is for.DeathAlchemy wrote:
Sorry i got really excited
also while trying to build the application this happened...http://imgur.com/sbEvLxU
However the issue there seems to be the path to JSON_Parser.cpp is incorrect.
http://imgur.com/gIWLZukabraker wrote:
Make sure you have these set correctly, referencing where the files are. Also this IS NOT an application, it's a library.
built went well but now a lib file is missing.abraker wrote:
Pull the new update. I separated the headers and sources into their own folders.
Change the target.abraker wrote:
this IS NOT an application, it's a library.
.I might not fully understood what you meant, but I did it this way to make the coding cleaner. If I didSoinou wrote:
The usage seems awfully hard for what it does, I mean instead of registering the parameters as params[whatever], then call the get method, why not just call the get methods with the parameters ?
Osu_Info::getInfo(Osu_Info::MODE::get_user_best, "param1", "param2", "param3", etc);Then the order of the parameters would matter and in most cases not all paramaters will be used. Consider this code:
// load parametersIf I was to do what you propose it would look like this:
params[U32 Osu_Info::PARAM::user_ID] = "abraker";
params[U32 Osu_Info::PARAM::game_mode] = GAMEMODE::Mania;
params[U32 Osu_Info::PARAM::limit] = "50";
user_best = Osu_Info::getInfo(Osu_Info::MODE::get_user_best, params);
Osu_Info::getInfo(Osu_Info::MODE::get_user_best, "abraker", "", "50", "", "", "", GAMEMODE::Mania, "");I suppose I can do this, but it looks ugly IMO.
I can't figure this out for the life of me! There doesn't seem an easy to do this within Visual Studio. I think I will have to create a new project and copy everything to the new folder. I'll do this in the next update.Soinou wrote:
Your project file is called Project4, you should probably rename it (You can juste rename it then reopen it, everything will work. Maybe you'll have to delete and reimport the vcxproj file, but well ...)
XD well that slipped out of my coding standards some how. Nice Catch! Will fix in the next update, and yes it's just wrong.Soinou wrote:
Oh, and you have something agains conventions it seems. You have JSON_Parser, OsuInfo, download as filenames. You can't have three name conventions for three files, that's just wrong.
Will do.Soinou wrote:
Instead of using static methods on a class, consider making this class a singleton.
Do I? I am using it as a string.Soinou wrote:
If you want to use constants that are 0/1/2/3, instead of putting them in a namespace and making them strings, just use an enumeration, they will be considered as integers. Or just pass the game mode as a third arguments and use defines, it will be the same and probably faster since you will in the end pass numbers directly.
if (_param[U32 PARAM::game_mode] != "")I could pass it as a 3rd parameter, but I want to keep consistency. All parameters will be passed through an array of 8 strings.
url += ("m=" + _param[U32 PARAM::game_mode] + "&");
I agree and was thinking of doing so. Perhaps it's my laziness of bothering of including other libraries that lead to this. I might consider doing this after the next update.Soinou wrote:
You should use a JSON library instead of creating your own or copying it from somewhere else. Use something like JsonCpp or any other library of the kind. They're easy to use, have a lot of useful functionalities and make your code simpler. Libraries are made to be reused, you should use them. Don't recode something that is already coded.
You mean typedef? If so, I did it for the previous design with tables, but didn't feel like vector<vector<string>> needed one. Though, I can make it so.Soinou wrote:
You are returning weird arrays from your functions. Why not make a custom type, like an OsuUser or an OsuBeatmap and return it ? Seems a lot easier to code and use.
I realized I didn't use the instance variable declared in the singleton classes and is fixed now. Other than that, I am not sure if you pointed me there due to design or incorrect implementation, so I'll address both. Honestly I am split between the static design and singleton design. If you think my implementation of a singleton is wrong, mind pointing out where and/or how?Nabile wrote:
You might want to read this about singletons.abraker wrote:
- - And Made the static classes singletons
Singletons are a solution in the short term. As explained in the chapter, they are going to be a pain in the long term (for reasons described in Why we regret using it).abraker wrote:
I realized I didn't use the instance variable declared in the singleton classes and is fixed now. Other than that, I am not sure if you pointed me there due to design or incorrect implementation, so I'll address both. Honestly I am split between the static design and singleton design. If you think my implementation of a singleton is wrong, mind pointing out where and/or how?
Since I am split between the two, I followed Soinou's advice. Unless those classes will be extended and the code becomes more complex, I don't think it matters which design I use.Soinou wrote:
Instead of using static methods on a class, consider making this class a singleton.
Actually, it totally does matter. Singletons are much harder for anyone to extend. Programming is one of the few places where considering how things might change in the future can be extremely helpful. Singletons are extremely difficult to refactor compared to other approaches, among other issues.abraker wrote:
Unless those classes will be extended and the code becomes more complex, I don't think it matters which design I use.
I am probably seeing this in the perspective where I can't imagine why you would want to extend the classes in this library. Just in case that I'm missing something, there is the static approach and singleton approach. Is there a better approach to this? The original idea was to make everything static so that the code would be clean while forcing there to be only one copy of the class.Bobbias wrote:
stuff
