[resolved] [confirmed] Rounding errors in osu!mania editor

Bobbias

Joined March 2011

Topic Starter

Bobbias 2014-11-10T06:56:34+00:00

Reikosaka and ExPew asked me to check this out. It appears that the 'Resnap All Notes' feature has a rounding problem, and aimod doesn't pick these unsnapped notes up.

For example, in Azu - Haryu's Another difficulty, some notes are off by 1ms from their correct timing. For example 01:42:705 (102705|6,102705|5,102706|4) - if you notice in the link, one of these notes is 1ms later than the others. The notes directly after those 01:42:844 (102844|3,102844|0) - are also off by 1 ms.

I'm not sure of more examples because 1ms error is hard to find, especially since AIMod doesn't pick them up, but that's no excuse for leaving this unfixed either.

Damnae

Elite Storyboarder

640 posts

Joined July 2011

Damnae 2014-11-10T07:21:56+00:00

I'm starting to see this for standard too, AIMod used to find 1ms unsnapped notes caused by copying a group of objects, but now it doesn't anymore..

For example in https://osu.ppy.sh/b/533434 , 02:24:134 (3) - is unsnapped but AIMod doesn't detect it.

JamesHappy

678 posts

Joined January 2014

JamesHappy 2014-11-10T10:00:37+00:00

same problem as mine

See this it's unsnapped

But AIMod doesn't detect (ignore the two warnings)

shionelove

1,522 posts

Joined September 2010

shionelove 2014-11-11T14:42:57+00:00

https://osu.ppy.sh/forum/t/122319

Rumia-

2,531 posts

Joined July 2012

Rumia- 2014-11-11T15:44:36+00:00

but in mania it doeeeeessss give a huge difference.

Bobbias

1,447 posts

Joined March 2011

Topic Starter

Bobbias 2014-11-11T17:35:10+00:00

hutunohito wrote:
https://osu.ppy.sh/forum/t/122319

I'm not complaining that AIMod doesn't find these. I'm complaining that it happens in the first place. The problem is not AIMod, the problem is notes being placed at the wrong timing.

Spy

2,551 posts

Joined November 2011

Spy 2014-11-11T22:28:13+00:00

I'm a person who unqualified this map by this reason,so I can confirm it.

Ayachi-

2,261 posts

Joined November 2013

Ayachi- 2014-11-11T22:29:47+00:00

OK. Here is my opinion on this situation.
There has been quite few maps with this 1 ms unsnapped problem, also my maps.
This problem is caused by the .osu format problem and it used to be ignored.
As you can see, asd123iii's map, Azu - Haryu, had been unranked once before because there was 1 ms unsnapped notes in the Hyper difficulty. It was fixed and now appears in Another.
The 1 ms problem will not be solved, and we could not fix it since AImod will not show unsnapped notes that are less than 2 ms
Even we could move the offset off by 1 and the original 1 ms unsnapped note will show on AImod because it became 2 ms.
Hutunohito tried this way and fixed all the 1 ms, there wasn't any unsnapped note after he fixed those, but after a few days, he discovered more unsnapped note.
The problem could not be fixed even AImod is able to detect 1 ms unsnapped note.
Here I suggest we can rank a map with unsnapped note that is 1 ms, and not unrank asd123iii's map.
Or the .osu problem can be fix soon.
I prefer the second way since there may still be a problem since it is unsnapped

I really hope the problem will get fixed soon, or mania ranking process will be stopped

shionelove

1,522 posts

Joined September 2010

shionelove 2014-11-11T22:42:03+00:00

There has been 1ms since osu started
It is .osu problem
If 1ms is unrank issue,we must wait for fixing .osu
It takes long time and may cause another many issues
because of changing format
This is the end of osu

TheVileOne

osu! Alumni

8,431 posts

Joined March 2010

TheVileOne 2014-11-11T23:50:55+00:00

I'm looking into making snapping perfect.

Edit: This issue isn't very easy to fix. This 1 ms difference is there due to how slider velocity works; it creates overlap at the end of the slider or makes the slider end go short.

Now about osu!mania. I am still investigating. Resnapping seems to work for me.

Edit: Replicated the snapping problem.

1 ms snapping issues in mania seem to be more common than you would think. The test maps I have checked seem to have randomly unsnapped 1 ms objects. This is not a recent phenomenon. Although my code may be contributing to it somehow.

Edit: Should be fixed. Sorry about that. One would think that each tick would be the same length, but alas it is not so.

BanchoBot

w00t p00t

34,832 posts

Here since the beginning

BanchoBot 2014-11-12T05:13:10+00:00

This issue has been addressed by the following change by TheVileOne:

Fix mania objects snapping incorrectly.

It will be applied to builds newer than b20141111.18cuttingedge.

Please follow up in this thread on the status of this issue after you have tested it. If it has not yet been resolved, please provide any new details that may have arisen since before this change.

asd123iii

283 posts

Joined October 2012

asd123iii 2014-11-12T06:00:05+00:00

I just fixed as AImod. But it's hard to check there's no more 1ms unsnapped....

http://puu.sh/cNqkg/7c8c435326.osz

Osu!version : b20141111.20cuttingedge

TheVileOne

osu! Alumni

8,431 posts

Joined March 2010

TheVileOne 2014-11-12T06:32:49+00:00

I can guarantee that every object is being snapped when you release the drag.

asd123iii

283 posts

Joined October 2012

asd123iii 2014-11-12T07:12:58+00:00

There's something went wrong.
When I use esc button close AImod directly.

Details

See the end of this message for details on invoking 
just-in-time (JIT) debugging instead of this dialog box.

************** Exception Text **************
System.ObjectDisposedException: Cannot access a disposed object.
Object name: '#ok'.
   at System.Windows.Forms.Control.CreateHandle()
   at System.Windows.Forms.Form.CreateHandle()
   at System.Windows.Forms.Control.get_Handle()
   at System.Windows.Forms.Form.set_Opacity(Double value)
   at #T.#GOb.#V2(Object , EventArgs )
   at System.Windows.Forms.Timer.OnTick(EventArgs e)
   at System.Windows.Forms.Timer.TimerNativeWindow.WndProc(Message& m)
   at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)


************** Loaded Assemblies **************
mscorlib
    Assembly Version: 2.0.0.0
    Win32 Version: 2.0.50727.5420 (Win7SP1.050727-5400)
    CodeBase: file:///C:/Windows/Microsoft.NET/Framework/v2.0.50727/mscorlib.dll
----------------------------------------
osu!
    Assembly Version: 0.0.0.0
    Win32 Version: 1.3.3.7
    CodeBase: file:///E:/Osu!/osu!.exe
----------------------------------------
System.Windows.Forms
    Assembly Version: 2.0.0.0
    Win32 Version: 2.0.50727.5420 (Win7SP1.050727-5400)
    CodeBase: file:///C:/Windows/assembly/GAC_MSIL/System.Windows.Forms/2.0.0.0__b77a5c561934e089/System.Windows.Forms.dll
----------------------------------------
System
    Assembly Version: 2.0.0.0
    Win32 Version: 2.0.50727.5420 (Win7SP1.050727-5400)
    CodeBase: file:///C:/Windows/assembly/GAC_MSIL/System/2.0.0.0__b77a5c561934e089/System.dll
----------------------------------------
System.Drawing
    Assembly Version: 2.0.0.0
    Win32 Version: 2.0.50727.5420 (Win7SP1.050727-5400)
    CodeBase: file:///C:/Windows/assembly/GAC_MSIL/System.Drawing/2.0.0.0__b03f5f7f11d50a3a/System.Drawing.dll
----------------------------------------
Microsoft.Xna.Framework
    Assembly Version: 1.0.0.0
    Win32 Version: 1.1.10405.0
    CodeBase: file:///E:/Osu!/Microsoft.Xna.Framework.DLL
----------------------------------------
msvcm80
    Assembly Version: 8.0.50727.4940
    Win32 Version: 8.00.50727.4940
    CodeBase: file:///C:/Windows/WinSxS/x86_microsoft.vc80.crt_1fc8b3b9a1e18e3b_8.0.50727.4940_none_d08cc06a442b34fc/msvcm80.dll
----------------------------------------
{7d30cd63-240a-4139-ab7a-081b5c2415d8}
    Assembly Version: 0.0.0.0
    Win32 Version: 1.3.3.7
    CodeBase: file:///E:/Osu!/osu!.exe
----------------------------------------
System.Configuration
    Assembly Version: 2.0.0.0
    Win32 Version: 2.0.50727.5420 (Win7SP1.050727-5400)
    CodeBase: file:///C:/Windows/assembly/GAC_MSIL/System.Configuration/2.0.0.0__b03f5f7f11d50a3a/System.Configuration.dll
----------------------------------------
System.Xml
    Assembly Version: 2.0.0.0
    Win32 Version: 2.0.50727.5420 (Win7SP1.050727-5400)
    CodeBase: file:///C:/Windows/assembly/GAC_MSIL/System.Xml/2.0.0.0__b77a5c561934e089/System.Xml.dll
----------------------------------------
osu
    Assembly Version: 1.0.0.0
    Win32 Version: 1.0.0.0
    CodeBase: file:///E:/Osu!/osu.DLL
----------------------------------------
osu!ui
    Assembly Version: 1.0.0.0
    Win32 Version: 1.0.0.0
    CodeBase: file:///E:/Osu!/osu!ui.DLL
----------------------------------------
System.Runtime.Remoting
    Assembly Version: 2.0.0.0
    Win32 Version: 2.0.50727.5420 (Win7SP1.050727-5400)
    CodeBase: file:///C:/Windows/assembly/GAC_MSIL/System.Runtime.Remoting/2.0.0.0__b77a5c561934e089/System.Runtime.Remoting.dll
----------------------------------------
System.Data
    Assembly Version: 2.0.0.0
    Win32 Version: 2.0.50727.5420 (Win7SP1.050727-5400)
    CodeBase: file:///C:/Windows/assembly/GAC_32/System.Data/2.0.0.0__b77a5c561934e089/System.Data.dll
----------------------------------------
Microsoft.Ink
    Assembly Version: 6.1.0.0
    Win32 Version: 6.1.7600.16385
    CodeBase: file:///C:/Windows/assembly/GAC_32/Microsoft.Ink/6.1.0.0__31bf3856ad364e35/Microsoft.Ink.dll
----------------------------------------
osu!gameplay
    Assembly Version: 1.0.0.0
    Win32 Version: 1.0.0.0
    CodeBase: file:///E:/Osu!/osu!gameplay.DLL
----------------------------------------
System.Management
    Assembly Version: 2.0.0.0
    Win32 Version: 2.0.50727.5420 (Win7SP1.050727-5400)
    CodeBase: file:///C:/Windows/assembly/GAC_MSIL/System.Management/2.0.0.0__b03f5f7f11d50a3a/System.Management.dll
----------------------------------------
dynamicBASSNET
    Assembly Version: 0.0.0.0
    Win32 Version: 1.0.0.0
    CodeBase: file:///E:/Osu!/osu.dll
----------------------------------------
mscorlib.resources
    Assembly Version: 2.0.0.0
    Win32 Version: 2.0.50727.5420 (Win7SP1.050727-5400)
    CodeBase: file:///C:/Windows/Microsoft.NET/Framework/v2.0.50727/mscorlib.dll
----------------------------------------
System.Windows.Forms.resources
    Assembly Version: 2.0.0.0
    Win32 Version: 2.0.50727.4927 (NetFXspW7.050727-4900)
    CodeBase: file:///C:/Windows/assembly/GAC_MSIL/System.Windows.Forms.resources/2.0.0.0_zh-CHT_b77a5c561934e089/System.Windows.Forms.resources.dll
----------------------------------------

************** JIT Debugging **************
To enable just-in-time (JIT) debugging, the .config file for this
application or computer (machine.config) must have the
jitDebugging value set in the system.windows.forms section.
The application must also be compiled with debugging
enabled.

For example:

<configuration>
    <system.windows.forms jitDebugging="true" />
</configuration>

When JIT debugging is enabled, any unhandled exception
will be sent to the JIT debugger registered on the computer
rather than be handled by this dialog box.