The placement of notes feels a little random so I'll just do a runthrough of some basics of rhythm:
Here's a so called
measure (set of four beats):
It begins on large white ticks, noted by red arrows. Also known as
downbeats.
The yellow arrows point to
offbeats.
The blue arrow points to
onbeats.
Downbeats are usually the strongest beats and therefore they're often emphasized the most in the map.
They're most commonly clickable (have circles and/or sliderheads on them).
Offbeats are usually the weakest beats (excluding beats on ticks in between the white ticks).
They're often very good to place claps on because that way the claps are heard the best.
Onbeats are often stronger than offbeats, but weaker than downbeats.
With your map you want to reflect the song as much as possible while still making a fun map.
In order to reflect the stronger beats, you have to emphasize them from weaker beats.
This is often done by making them clickable. It wouldn't really make sense to lift your finger on-, or worse, completely ignore stronger beats.
Now that we got that out of the way I'll try giving some examples of what you could improve (in my opinion).
First of all, your beat snap divisor on easy is 1/1 while on hard it's 1/4. Even though you don't map 1/2 or 1/4s on easy, I still think you should keep it at 1/4 so it's easier to traverse through, as right now it feels quite strange switching between the various difficulties in edit mode. It's not necessary to change though.
00:02:138 - Right here we see an example of missed emphasization. This beat is currently a sliderend, but it's stronger than 00:01:229 - is.
In order to fix this, I'd have done it like this:
Or, by using a repeat you could do it like this: (this is just personal, but I think repeats emphasize things more than sliderends)
00:03:956 - Here's a downbeat, make it clickable.
00:08:501 - This is good, even though it's an offbeat it still has a distinctive sound on it, so this is ok.
What's even better is that it's keeping a consistent pattern with other measures, like this is also the first offbeat 00:12:138 - , and 00:15:774 - too.
Keep this up and it'll be really good. Just remember to vary it as well so it doesn't get repetitive.00:19:410 - First offbeat is not a slider, which breaks consistency with previous patterns.
I would've made it a repeat to emphasize 00:20:320 - at the same time.
You're using too little repeats in this difficulty, in my opinion, try using a few more.
Just remember to make sure they only repeat once, because more could get confusing for new players.
00:22:138 (1,2,3,1,2,3) - This I like as well, because they're consistent. Both downbeats are circles, both first offbeats are circles, both onbeats are sliderheads and both second offbeats are sliderends.
By making them consistent like this it'll help define the rhythm a lot more, well done.The following measures are also consistent, nice.00:56:683 - I think you should make this a repeat for consistency with 00:53:047 - .
01:02:138 - As you may notice, not all downbeats have strong beats on them. This one has a rather low pitch, which is why it's alright to end a slider on it. They do often have stronger beats, though, so you should still watch out for them.
01:03:047 (1) - I don't think it'll be very intuitive to play nor fun to watch a straight line, so perhaps you could change this a bit. I see the other mods have suggested some sort of sliderart, so I'll give an example of how slider art could look (though I'm not the best at it so take it with a grain of salt lol).
It's usually best to place red control points on the sliderticks, since they often have beats on them.
It's basically just about experimenting a bit and trying to not make it look too rough.
Try making it both look good and play well.
Easy
