One, it is not. Your friend is running a private business and he is technically selling image files that just happen to come together to make an osu! skin.
Two, even if it is, there are certain other actions that directly violate the Terms of Service that get ignored for the sake of the game's growth and that of its community. I'm pretty sure selling skins is the least of your friend's worries.