Guest
home
beatmaps
rankings
community
store
help
forum
  1. Forums
  2. Beatmaps
  3. Mapping Discussion
  4. Ranking Criteria
  5. Finalized/Denied Amendments

Fix Applause filetype rule to guideline

posted
Total Posts
13
Noffy
Nomination Assessment Team
1,685 posts
Joined April 2012
Topic Starter
Noffy
As it currently fails to consider cases where a .wav file would be smaller such as blanks files, or other edge cases.

current rule:
Applause files and other passive hitsounds must use the .mp3 or .ogg file formats. These files usually have long durations and .wav files are unnecessarily large in comparison.


proposed guideline:
Applause files and other passive hitsounds should use the .mp3 or .ogg file formats. These files usually have long durations and .wav files are unnecessarily large in comparison. The `.wav` file format is only allowed when this would yield a smaller filesize, such as in blank applause files.


Would like to fix this soon so please give feedback :)
Last edited by Noffy , edited 1 time in total.
celerih
617 posts
Joined July 2014
celerih
Yes good change, wording seems fine to me but I'm not very good at it so
tatatat
923 posts
Joined March 2015
tatatat
sounds good to me.

You might want to add a clause about bitrate for .mp3 applauses/other passive hitsounds. Theres really no need for them to be above 192/320kbps if they aren’t a .wav.

I think .wav files might still have a place in extremely short files, like a short pauseloop, or fail sound, where they are generally 0.1 to 3 seconds in length.
Last edited by tatatat , edited 2 times in total.
pishifat
osu! Paragon
3,812 posts
Joined August 2013
pishifat
Applause files and other passive hitsounds should use the .mp3 or .ogg file formats. These files usually have long durations and .wav files are unnecessarily large in comparison, however .wav should be used when it results in a smaller file size.

same but shorter?
Genjuro
656 posts
Joined August 2013
Genjuro
Pretty sure that's not the rule which needs rewording, should be changing:

"Completely silent hitsounds must use this 44-byte file. Other files have unnecessarily high file sizes and 0-byte files do not function."

so that it includes cases like the applause instead. The point is that silent audio files (not just hitsounds) should be using the 44-byte file for the sake of preserving space. I don't know all of the possible scenarios where a blank audio file can be used, but a wording like "Any silent audio files used in a beatmap must be using this 44-byte file as it's the most optimized one in terms of file size" or something of that sort.

Now for the rule mentioned:

"Applause files and other passive hitsounds must use the .mp3 or .ogg file formats. These files usually have long durations and .wav files are unnecessarily large in comparison."

It could be somewhat improved by changing the wording from "Applause files and other passive hitsounds" to "Audio files which are not used for providing tactile feedback".

so yeah tldr:

Audio files used for tactile feedback: .wav or .ogg
Audio files not used for tactile feedback: .mp3 or .ogg
Completely silent audio files: 44-byte file

Reword accordingly!
tatatat
923 posts
Joined March 2015
tatatat
I think if you use the word tactile feedback, it’ll have to be added to the glossary.
Genjuro
656 posts
Joined August 2013
Genjuro
Doesn't have to be used in the RC i just mentioned it here to explain my point.

What im trying to say is that we should separate active hitsounds, passive sounds (which includes both passive hitsounds and everything else like ambient noises or applauses) and silent sounds properly so that there's no confussion.
pishifat
osu! Paragon
3,812 posts
Joined August 2013
pishifat
genjuro's suggestion makes sense, but requiring someone to read a separate rule (silent hitsounds must use 44byte) to figure out the exception to another rule (applause/passive use mp3/ogg) kinda sucks since there's no real chronology to the rc. have any ways in mind to deal with this?
Genjuro
656 posts
Joined August 2013
Genjuro
I don't see how this would be an exception to another rule, people using a completely silent audio file should be following the rule on completely silent audio files. Also, if we change the wording according to my suggestion, there won't be any mention of applause to begin with therefore it won't mislead people.
tatatat
923 posts
Joined March 2015
tatatat
Just make the two rules close to each other in the RC?
Noffy
Nomination Assessment Team
1,685 posts
Joined April 2012
Topic Starter
Noffy
ok so overall thinking:

Applause files and other passive hitsounds should use the .mp3 or .ogg file formats. These files usually have long durations and .wav files are unnecessarily large in comparison, however .wav should be used when it results in a smaller file size.

as pishifat posted, as it makes it a guideline with the clear exception in the guideline

and

Completely silent sound files must use this 44-byte file. Other files have unnecessarily high file sizes and 0-byte files do not function.

so that this clearly covers all sound file cases and not just hitsounds.
Last edited by Noffy , edited 1 time in total.
Genjuro
656 posts
Joined August 2013
Genjuro
For the second one, use large instead of high when referring to file size, just noticed this inconsistency with the first rule and i think it's more correct overall so might as well fix it
Noffy
Nomination Assessment Team
1,685 posts
Joined April 2012
Topic Starter
Noffy
ah sure, fair enough. will make sure that wording is adjusted for PR time

edit: it has been done https://github.com/ppy/osu-wiki/pull/3316
Last edited by Noffy , edited 1 time in total.
Please sign in to reply.

New reply

0
1 / 13