- agree with "reasonable" being a bad word to use, i don't think "optional" has the same pitfall since to me it seems to categorically be specifying that you can't force a minor upgrade if the mapper doesn't want to, but regardless i think your suggested wording works to that end as well, so:Noffy wrote:
Writing a bunch of stuff like "reasonable" or "optional" in a rule is a mistake to begin with to be honest, they're not enforceable as a hard rule, besides applying it all the time, so it defeats the point of that phrasing.
It has the same problems as the current one
... I'm getting flashbacks to when I got told off when PRing a meta change for the same issue ahah
So I'd think we'd really need to re write it to avoid that kind of phrasing as much as possible.
- For better context:
The OLD old rule specified minimum 128kbps max 192 kbs. However this REQUIRED over encoding songs which did not have at least 128 quality audio in existence. This was changed to "reasonable" quality to avoid such contradictory practices but it looks like bad actors are making that backfire. Oof.propose noffy wrote:
- A song's audio file and hitsound files must be of reasonable quality. When possible, a song's audio must be at least 128kbps in quality. When the minimum is not possible, use the highest sub-128kbps quality audio available.
- A song's audio file must not be encoded to a bit rate more than 20kbps higher than the original files.
Reinstated 128 as general minimum, gets rid of reasonable quality all together. As long as they hit that minimum they're fine. This way the minimum exists without the old contradictory practice of up encoding songs that don't exist in at least 128.
Separates over encoding into its own rule so that it's easier to find and can be better specified.
- regarding your proposal, I agree with the first part, i think if you're going to change the 2nd encoding rule to that then it makes more sense to change it back to 32 since it's not really about minor improvements anymore but more about exporting at the wrong bitrate, and it's easier to recognise as well using the 128-160-192 threshold instead of requiring that precision
hence this is where i land:
- A song's audio file and hitsound files must be of reasonable quality. When possible, a song's audio must be at least 128kbps in quality. When the minimum is not possible, use the highest sub-128kbps quality audio available.
- A song's audio file must not be encoded to a bit rate more than or equal to 32kbps higher than the original files.