[resolved] [confirmed] osu crashes if the beatmap is longer than the audio file

Aqo

Joined April 2010

Topic Starter

Aqo 2014-01-22T17:18:29+00:00

Problem Details:
if I try to ctrl+c ctrl+v a long enough pattern (in edit mode obviously) that would extend outside of the end of the mp3/ogg then osu crashes as soon as I paste it.
if I replace the mp3/ogg of a map file with another one and then the map file ends up being longer than the mp3/ogg, osu crashes upon opening that map in edit mode.
basically, beatmaps longer than audio files make osu crash. please teach osu to deal with those cases as they're a common by-step when working on editing music/map files and sometimes during your work process you want to have a beatmap longer than the audio file; osu should be able to extend the timeline accordingly when needed and not just crash

osu! version: 20140121 (latest)

TheVileOne

osu! Alumni

8,431 posts

Joined March 2010

TheVileOne 2014-01-22T22:38:20+00:00

It isn't crashing for me. The notes that are outside the mp3 are removed when I test play.

Aqo

2,710 posts

Joined April 2010

Topic Starter

Aqo 2014-01-23T08:36:04+00:00

try in mania mode

Aqo

2,710 posts

Joined April 2010

Topic Starter

Aqo 2014-01-25T08:24:43+00:00

this issue is still around. please address this

easy way to reproduce: open any random mania map, press ctrl+a, ctrl+x, move to close to the map's ending, ctrl+v. congratulations your osu crashed

Ayesha Altugle

3,052 posts

Joined October 2011

Ayesha Altugle 2014-01-25T09:32:21+00:00

Aqo wrote:
this issue is still around. please address this

easy way to reproduce: open any random mania map, press ctrl+a, ctrl+x, move to close to the map's ending, ctrl+v. congratulations your osu crashed

I was able to replicate it and the error was this

Error 1

System.IndexOutOfRangeException: Index was outside the bounds of the array.
at #Ei.#Ii.#7O()
at osu.GameModes.Edit.Editor.#7O()
at osu.GameModes.Edit.Editor.#Ls()
at #rb.#xb.#Ls()
at #1h.#0h.#Ls()
at #rb.#xb.#6s()
at #rb.#xb.#ht(Object , EventArgs )
at #rb.#Bb.#Ct()
at #rb.#Rb.#Rv(Object , EventArgs )
at System.Windows.Forms.Application.ThreadContext.System.Windows.Forms.UnsafeNativeMethods.IMsoComponent.FDoIdle(Int32 grfidlef)
at System.Windows.Forms.Application.ComponentManager.System.Windows.Forms.UnsafeNativeMethods.IMsoComponentManager.FPushMessageLoop(Int32 dwComponentID, Int32 reason, Int32 pvLoopData)
at System.Windows.Forms.Application.ThreadContext.RunMessageLoopInner(Int32 reason, ApplicationContext context)
at System.Windows.Forms.Application.ThreadContext.RunMessageLoop(Int32 reason, ApplicationContext context)
at System.Windows.Forms.Application.Run(Form mainForm)
at #rb.#Rb.#nt()
at #rb.#xb.#nt()
at #1h.#np.#Iwb(String , Boolean )

woc2006

409 posts

Joined September 2011

woc2006 2014-01-25T12:07:02+00:00

fixed

Rei Hakurei

1,983 posts

Joined February 2011

Rei Hakurei 2014-01-25T13:48:15+00:00

i remember told this to woc yesterday, even this thing is a duplicate for me.

TheVileOne

osu! Alumni

8,431 posts

Joined March 2010

TheVileOne 2014-01-30T00:14:38+00:00

Confirming until it is fixed on the test build.

peppy

19,300 posts

Here since the beginning

peppy 2014-01-30T04:39:35+00:00

Woc submitted a fix I didn't approve of, so this isn't fixed yet in any build.

Nathanael

Global Moderator

6,162 posts

Joined January 2013

Nathanael 2014-02-23T06:41:32+00:00

[woc2006] Fix osu crashes if the beatmap is longer than the audio file. (fixes /t/180877)

peppy

19,300 posts

Here since the beginning

peppy 2014-02-23T07:58:29+00:00

It's up on test build, if you'd like to actually confirm resolved.

Marcin

osu! Alumni

4,944 posts

Joined March 2011

Marcin 2014-02-23T08:34:34+00:00

Aqo wrote:
this issue is still around. please address this

easy way to reproduce: open any random mania map, press ctrl+a, ctrl+x, move to close to the map's ending, ctrl+v. congratulations your osu crashed

I was still able to reproduce it using this method on latest test version.

System.IndexOutOfRangeException: Index out of array range
   w #Ei.#Ii.#6O()
   w osu.GameModes.Edit.Editor.#6O()
   w osu.GameModes.Edit.Editor.#Ms()
   w #rb.#xb.#Ms()
   w #1h.#0h.#Ms()
   w #rb.#xb.#7s()
   w #rb.#xb.#it(Object , EventArgs )
   w #rb.#Bb.#Dt()
   w #rb.#Rb.#Sv(Object , EventArgs )
   w System.Windows.Forms.Application.ThreadContext.System.Windows.Forms.UnsafeNativeMethods.IMsoComponent.FDoIdle(Int32 grfidlef)
   w System.Windows.Forms.Application.ComponentManager.System.Windows.Forms.UnsafeNativeMethods.IMsoComponentManager.FPushMessageLoop(Int32 dwComponentID, Int32 reason, Int32 pvLoopData)
   w System.Windows.Forms.Application.ThreadContext.RunMessageLoopInner(Int32 reason, ApplicationContext context)
   w System.Windows.Forms.Application.ThreadContext.RunMessageLoop(Int32 reason, ApplicationContext context)
   w System.Windows.Forms.Application.Run(Form mainForm)
   w #rb.#Rb.#ot()
   w #rb.#xb.#ot()
   w #1h.#np.#Iwb(String , Boolean )