Guest
home
beatmaps
rankings
community
store
help
forum
  1. Forums
  2. osu!
  3. Help
  4. Resolved Issues

Green lines resetting for guest map submission(Important) [confirmed] [resolved]

posted
Total Posts
34
TheVileOne
osu! Alumni
8,431 posts
Joined March 2010
Topic Starter
TheVileOne
Okay. I am having a baffling issue. This is the second time I've sent a guest difficulty to someone and they submit it, and all of my inherited changes are reset to whatever green lines the other maps have or perhaps it's the green lines the map I made the difficulty from once had. It's usually fixed after my difficulty is submitted and they resubmit with the fixed green lines. The issue seems to lie with the BSS thinking that my guest difficulty is in some way using the same green lines as the difficulty that I created it from when i made slight changes to those green lines/added a few of my own.

This bug could cause serious loss of work if one does not keep the backup once its updated, so please get right on this.
Last edited by TheVileOne , edited 1 time in total.
ryza
679 posts
Joined October 2011
ryza
YES. PLEASE FIX THIS.

I have had to re-do my inherited points on my map multiple times, and it is seriously frustrating. Whenever I submit it seems to randomly distribute them across difficulties.

I'm not sure what exactly triggers it, but earlier I removed all inherited points from my normal difficulty and submitted. After that, they were all gone from insane as well. I added them back into insane, submitted, and now they're in the normal again!

I can't finish my map if this keeps up. ><
peppy
19,316 posts
Here since the beginning
peppy
Do you happen to have more than one copy of the same difficulty elsewhere in your songs folder?
ryza
679 posts
Joined October 2011
ryza

peppy wrote:

Do you happen to have more than one copy of the same difficulty elsewhere in your songs folder?
I just checked, and do not see any duplicates.
Flanster
5,938 posts
Joined August 2010
Flanster
my diff's SV and hitsounds borkd when eLtigreXXx submitted his new map so im confirming this.

/p/1843588
TheVileOne
osu! Alumni
8,431 posts
Joined March 2010
Topic Starter
TheVileOne
No. I mentioned I sent them a guest difficulty. I made a difficulty, put it in a zip file and puushed it to them. In both cases they submitted it and I updated the map and my green lines changes weren't there anymore. I was not the one who submitted the version, so I don't see how there could be a contamination.

It would also be nice if you fixed the equally annoying saving bug with green lines. I'll save making another thread for this bug.

If I delete a green line (unsure about adding one) and save and test without making any changes to hitobjects, the green lines will just reappear. The editor doesn't seem to consider changes to green lines as an official change to a beatmap so it ignores it.
[Luanny]
8,248 posts
Joined April 2011
[Luanny]
This. Is. Fucking. Annoying.
Confirming this :v
peppy
19,316 posts
Here since the beginning
peppy
Can you check whether changes are written to the .osu file when you make them? From my end they seem to be occurring.
Sekai
6,376 posts
Joined February 2011
Sekai
yeah it's happens to me, on my map guest diff ._. i have to copy the timing again and ofc submit it~

This should be fixed fast orz
TheVileOne
osu! Alumni
8,431 posts
Joined March 2010
Topic Starter
TheVileOne
I'm not really sure how to check for that. I don't know what the specifics are that cause the bug. It is not on my end though. Unless updating my map by clicking update is somehow ignoring my changes. There just no way this is not a bug, because this never happened before the latest build, and I know my green lines were intact in the puush.

If anyone has a good idea on how to replicate this issue, please share.
lolcubes
osu! Alumni
4,437 posts
Joined November 2010
lolcubes
Is it possible to link the map in question? Just to have a look.
TheVileOne
osu! Alumni
8,431 posts
Joined March 2010
Topic Starter
TheVileOne
it is, but in both issues, the problems was resolved. Once a beatmap is submitted into the system, updating changes to that beatmap work pretty flawlessly as far as I know.

Happened with

/p/1829886 and http://osu.ppy.sh/s/60481
h3k1ru
osu! Alumni
1,910 posts
Joined March 2010
h3k1ru

TheVileOne wrote:

Okay. I am having a baffling issue. This is the second time I've sent a guest difficulty to someone and they submit it, and all of my inherited changes are reset to whatever green lines the other maps have or perhaps it's the green lines the map I made the difficulty from once had. It's usually fixed after my difficulty is submitted and they resubmit with the fixed green lines. The issue seems to lie with the BSS thinking that my guest difficulty is in some way using the same green lines as the difficulty that I created it from when i made slight changes to those green lines/added a few of my own.

This bug could cause serious loss of work if one does not keep the backup once its updated, so please get right on this.
^ can confirm every word there. just did upload a bunch of guest diffs and got the same bug, its very annoying to hand fix all green lines after submit, and resubmit again lol

how to replicate:

lets say we have a original mapper diff A and guest diff B

diff A was submitted first and the mapset have only 1 diff inside it on osu site

then u need to submit guest diff B, there goes 2 cases

1. u do submit from diff A (in editor diff A is opened and u want to upload diff B) then, after submit, diff B lose it green lines. actually green lines not lost, they just get copy pasted from diff A during submit on editor purpose.

2. u do submit from diff B, then u lose green lines on diff A (green lines on diff A becomes from diff B)

peppy wrote:

Can you check whether changes are written to the .osu file when you make them? From my end they seem to be occurring.
my thoughts why this happen:

BeatmapID:1111

coz of both diff A and diff B have the same BeatmapID before u do upload? so editor copy green lines during submit, and then when diff B get unique BeatmapID u can fix green lines by reuploading diff? idk~
peppy
19,316 posts
Here since the beginning
peppy
If you are making a new map, use the "new difficulty" options in the editor. Don't use an existing one. This will obviously cause issues due to the beatmap information stored in the .osu file being incorrect.

If you must use an existing one, clear the beatmapid and beatmapsetid lines, at very least.
h3k1ru
osu! Alumni
1,910 posts
Joined March 2010
h3k1ru

peppy wrote:

If you are making a new map, use the "new difficulty" options in the editor. Don't use an existing one. This will obviously cause issues due to the beatmap information stored in the .osu file being incorrect.
just tested it, even if u press "new difficulty" and then "ok" for "start fresh" or w/e, the new difficulty keep the parent BeatmapID~

peppy wrote:

If you must use an existing one, clear the beatmapid and beatmapsetid lines, at very least.
is it temporary solution for submitting new diffs? clear BeatmapID in notepad?
peppy
19,316 posts
Here since the beginning
peppy
Yes.
Sekai
6,376 posts
Joined February 2011
Sekai
orz it's happening again to me ._. and it toke me while to do it orz....shouldn't this be solved or something >< it's really annoying ~
TheVileOne
osu! Alumni
8,431 posts
Joined March 2010
Topic Starter
TheVileOne
Why are my maps still affecting either the green lines of maps in the set or my lines getting reset again? I mean it's happened with every single guess difficulty I've made except one. I don't feel safe submitting difficulties for the first time anymore or accepting guest difficulties, because unless I check to see if they used the proper method for making a guest difficulty, my green lines could just happen to be overwritten.
Rei Hakurei
1,983 posts
Joined February 2011
Rei Hakurei
maybe to replicate this is make a map with multiple timing (required at least a red)
with timing differences in each diff.. well i've encountered this a long ago and i think that is looks like my change but not.. http://ha.ppy.sh/s/222
that map is the sample..
the normal diff is not synced the timing with extra or taiko diff..
by full/first submitting it, it could have a chance to replicate in synchronizing all maps in set.. part i think~

(also, my new submitted map gives that synchronizing timing bug, it synchronizes the timing with current opened diff, and i quickly resynced back to the default~)
TheVileOne
osu! Alumni
8,431 posts
Joined March 2010
Topic Starter
TheVileOne
I can confirm. I don't know why this synchronizing beatmap processing is occuring. Whenever it happens it resets lines in my guest difficulty or all the difficulties that are not the guest difficulty. This is not helpful in anyway.

BTW I checked the guest difficulty beatmap id for the difficulty that triggered the sync, and it was -1. You got to stop this, because even with the proper beatmap id being reset, this happens anyways.

Happened with http://osu.ppy.sh/s/58384

This difficulty http://puu.sh/1qVSo
TheVileOne
osu! Alumni
8,431 posts
Joined March 2010
Topic Starter
TheVileOne
This is getting old. It keeps happening and it's consistently happening.

Upload a beatmap
Make a difficult by Save as new difficulty.
Change the green lines.
Submit that difficulty in a different difficulty (if it doesn't work, try submitting it in the same difficulty you create it new from)

It works every single time (for me).

p/1932454#p1932454 happened with this


I just checked and my map shares the same beatmapid with the difficulty I saved as new difficulty from. So whatever the BSS or the editor is doing, something is changing the beatmapid to the same id as the difficulty you created it from. Unless it was like that before, then even saving as new difficulty gives the same beatmapid. Somehow my difficulty had the same beatmap id and i saved as new difficulty. I always do.
peppy
19,316 posts
Here since the beginning
peppy
This should be fixed in the next public release (likely tomrorow). Please test and report back.
TheVileOne
osu! Alumni
8,431 posts
Joined March 2010
Topic Starter
TheVileOne
Hopefully its fixed, because I just figured out why it happens too.

Actually the beatmapid didn't properly reset for some reason and thats why it happens.

Other bug I guess. Unsure if this is related.

When BSS submits a new map, that map opens during submission. When submission is finished, it bugs out, because it thinks that you're in the new map, but you're really in the map you submitted in.
Rei Hakurei
1,983 posts
Joined February 2011
Rei Hakurei
the other bug i can confirm it by looking at the osu title that changes like having iteration to every diff~ but it just title changing and .. wait.. in that process too where the timing synchronizing happens..
peppy
19,316 posts
Here since the beginning
peppy
New build is up. Please test this. In the case it is still not fixed I still have some more ideas on how to fix; I only fixed the beatmap id propagation for now.
TheVileOne
osu! Alumni
8,431 posts
Joined March 2010
Topic Starter
TheVileOne
Nope still broken. If you want to replicate.

Create a new difficulty.
Change green lines, and make sure that the changes to green lines save.
Have the beatmap detect the difficulty (unsure if open difficulty will work)
Go into the map you made the new difficulty, and submit. (It probably works with any difficulty. If my theory is correct, it will copy the timing lines of the difficulty you submit with into the new difficulty)
Still overwrites

The beatmapid is unique. I do not think it's a problem.

I swear it has something to do with this.

Look at the top bar and look at the difficulty name. BSS switches to the new difficulty automatically when you submit, even though you're still in the difficulty you submitted in.
peppy
19,316 posts
Here since the beginning
peppy
Yeah, I see what you mean. I was just hoping the beatmap id change alone would resolve the switching issue. Unfortunately some of this code was not written by me so I'm not as familiar with it as normal. I'll do some more thorough testing before next build.
peppy
19,316 posts
Here since the beginning
peppy
Please test this again.
TheVileOne
osu! Alumni
8,431 posts
Joined March 2010
Topic Starter
TheVileOne
I tested, and the green lines didn't reset. although a little down in the update, it still changes the menu bar to the new difficulty. I assume you made it so that the new difficulty updates later, so that it doesn't get confused with the current difficulty. Well It's looking good although IDK if it was just me but it took an abnormally long time to create the changes. Usually the upload beatmap would popup right away but it took a bit of time.

Something else that was unusual is that it said creating package before I picked update beatmap, and after I picked it. Why would it prompt me to update beatmap in the middle of an update process? Maybe my memory is going.

It seems to be fixed. My map normally takes awhile to update due to multiple backgrounds. Perhaps a further optimization would be to actually recognize multiple background usage.
peppy
19,316 posts
Here since the beginning
peppy
The time taken to update depends on the overall size of your map. It can be improved in a memory-reduction way, but the performance likely will not. This is to ensure overall integrity of the package, and should still be less time than the full file upload would have taken.

I will look into the issues you mention, but I did not actually change anythign that could have caused performance issues (as far as I can tell).
TheVileOne
osu! Alumni
8,431 posts
Joined March 2010
Topic Starter
TheVileOne
It's not a big deal. That map has a rather large video, so it's probably why it takes longer. But eh I wouldn't see why it would need to process the video entirely. there might be a way to improve processing time with an ignore video during submission checkbox under advanced options. As long as it doesn't remove the video during submission that could greatly improve performance if the video needs to be checked each time.

It would actually be nice to see more beatmap submission options really. osz2 could really benefit from them.
peppy
19,316 posts
Here since the beginning
peppy
The method of submission involves binary difference calculations on the file as a whole. While this may not be the most efficient (it could be broken down to per-file), it is the easiest method of implementation, and ensures integrity at both ends. It also allows checking if headers are modified where they shouldn't have been, and reduces complexity of the system overall.

The idea behind osz2 and the new version of BSS is that there ARE no options. More options would be counter-productive.
TheVileOne
osu! Alumni
8,431 posts
Joined March 2010
Topic Starter
TheVileOne
This seems to be fixed except for the menu bar title change. I'm going to mark this as resolved. If I find out that it's still a problem for one reason or another, I can unresolve it. I'm not sure if Natsume Rin's problem with cancelling mid upload still resets inheriteds or not though, but there's a separate thread for that.

Edit: Actually I'll hold off from resolving. I want to see if changing the difficulty name alone will cause havoc with a submitted beatmap. If the beatmapid is the same as another difficulty, will the inheriteds overwrite. Because if it does, the only safe way to upload a guest difficulty with a newer mapper is to check the beatmapid before submission.
peppy
19,316 posts
Here since the beginning
peppy
I've made the behaviour a bit more verbose to avoid issues including the window title being set incorrectly. May require further testing, but works well for me.
Please sign in to reply.

New reply

0
1 / 34